Project

General

Profile

Actions

Cleanup #61746

closed

backport-resolve-issue: fix script to handle RC versions

Added by Laura Flores 11 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

The "backport-resolve-issue" script (https://github.com/ceph/ceph/blob/main/src/script/backport-resolve-issue) does not handle RC (release candidate) versions.

To fix this issue, try this diff:

 def usage():
     logging.error("Redmine credentials are required to perform this operation. " 
@@ -522,7 +528,10 @@ Ceph version:     base {}, target {}'''
         maybe_stable = "v{}.{}".format(x, y)
         assert ver_to_release()[maybe_stable], \
             "SHA1 {} is not based on any known stable release ({})".format(sha1, maybe_stable)
-        tv = "v{}.{}.{}".format(x, y, int(z) + 1)
+        if int(y) == 0:
+            tv = "v{}.{}.{}".format(x, 1, z)
+        else:
+            tv = "v{}.{}.{}".format(x, y, int(z) + 1)
         if tv in version2version_id:
             self.target_version = tv
         else:

Actions #1

Updated by taki zhao 10 months ago

Laura Flores wrote:

The "backport-resolve-issue" script (https://github.com/ceph/ceph/blob/main/src/script/backport-resolve-issue) does not handle RC (release candidate) versions.

To fix this issue, try this diff:
[...]

I make a pull request here.
https://github.com/ceph/ceph/pull/52838

Actions #2

Updated by Laura Flores 9 months ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 52838
Actions #3

Updated by Laura Flores 9 months ago

Thanks for your contribution! I will take a look.

Actions #4

Updated by Laura Flores 9 months ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF