Tools » teuthology

pull request #151.

I am confused. There was only one really small basic change suggestion and I am not sure how the rest of the review is at all dependent on making that one change? Are we confusing branches? I was waiting on the rest of the review as I thought the rest of the review was going to happen later?

Let's get in the habit of linking PRs so people don't have to go find them.
https://github.com/ceph/teuthology/pull/151/

Apologies, I should have kept going with review starting that next Monday while you were on vacation.

One thing that we need with changes like this is documentation - I don't know what all these new functions intend to do and comments would go a long way. For example, a function called 'need_to_install_distro' is calling 'sudo yum install' on a remote system. Why?