Ceph

When i read the source code of teuthology about ceph ansible, i found a code problem:

def get_scratch_devices(remote):
    """ 
    Read the scratch disk list from remote host
    """ 
    devs = []
    try:
        file_data = remote.read_file("/scratch_devs").decode()
        devs = file_data.split()
    except Exception:
        devs = remote.sh('ls /dev/[sv]d?').strip().split('\n')

    # Remove root device (vm guests) from the disk list
    for dev in devs:
        if 'vda' in dev:
            devs.remove(dev)
            log.warning("Removing root device: %s from device list" % dev)

    log.debug('devs={d}'.format(d=devs))

    retval = []
    for dev in devs:
        dev_checks = [
            [['stat', dev], "does not exist"],
            [['sudo', 'dd', 'if=%s' % dev, 'of=/dev/null', 'count=1'], "is not readable"],
            [
                [run.Raw('!'), 'mount', run.Raw('|'), 'grep', '-v', 'devtmpfs', run.Raw('|'),
                'grep', '-q', dev],
                "is in use" 
            ],
        ]
        for args, msg in dev_checks:
            try:
                remote.run(args=args)
            except CommandFailedError:
                log.debug(f"get_scratch_devices: {dev} {msg}")
                break
        else:
            retval.append(dev)
            continue
        break
    return retval

and you can found this code on: https://github.com/ceph/teuthology/blob/main/teuthology/misc.py#L790

Please check the `else` position is ok ? I am a fresh man in Python. Is `else`'s writing method legal?

Based on the semantics here, I plan to change it to this format:

def get_scratch_devices(remote):
    """ 
    Read the scratch disk list from remote host
    """ 
    devs = []
    try:
        file_data = remote.read_file("/scratch_devs").decode()
        devs = file_data.split()
    except Exception:
        devs = remote.sh('ls /dev/[sv]d?').strip().split('\n')

    # Remove root device (vm guests) from the disk list
    for dev in devs:
        if 'vda' in dev:
            devs.remove(dev)
            log.warning("Removing root device: %s from device list" % dev)

    log.debug('devs={d}'.format(d=devs))

    retval = []
    for dev in devs:
        dev_checks = [
            [['stat', dev], "does not exist"],
            [['sudo', 'dd', 'if=%s' % dev, 'of=/dev/null', 'count=1'], "is not readable"],
            [
                [run.Raw('!'), 'mount', run.Raw('|'), 'grep', '-v', 'devtmpfs', run.Raw('|'),
                'grep', '-q', dev],
                "is in use" 
            ],
        ]

        checkRet = True
        for args, msg in dev_checks:
            try:
                remote.run(args=args)
            except CommandFailedError:
                checkRet = False
                log.debug(f"get_scratch_devices: {dev} {msg}")
                break

        if checkRet:
            retval.append(dev)

    return retval

I don't know if my ideas are correct. If they are correct, I am willing to submit a PR.