Bug #57480: mgr/telemetry: log exceptions as "exception" instead of "error" - mgr - Ceph

Actions

Copy link

Bug #57480

closed

mgr/telemetry: log exceptions as "exception" instead of "error"

Added by Laura Flores over 1 year ago. Updated 10 months ago.

Status:

Resolved

Priority:

Normal

Assignee:

Category:

telemetry module

Target version:

% Done:

100%

Source:

Tags:

low-hanging-fruit backport_processed

Backport:

quincy

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

48152

Crash signature (v1):

Crash signature (v2):

Description

See relevant code and fixes here:

https://github.com/ceph/ceph/blob/f4bb197f3e16c40b741945a0a40f8bd707661e73/src/pybind/mgr/telemetry/module.py#L596-L598

except (json.decoder.JSONDecodeError, KeyError) as e:
-    self.log.error("Error caught on {}.{}: {}".format(daemon_type, daemon_id, e))
+    self.log.exception("Error caught on {}.{}: {}".format(daemon_type, daemon_id, e))
    continue

https://github.com/ceph/ceph/blob/f4bb197f3e16c40b741945a0a40f8bd707661e73/src/pybind/mgr/telemetry/module.py#L713-L715

except (json.decoder.JSONDecodeError, KeyError) as e:
-    self.log.error("Error caught on osd.{}: {}".format(osd_id, e))
+    self.log.exception("Error caught on osd.{}: {}".format(osd_id, e))
    continue

https://github.com/ceph/ceph/blob/f4bb197f3e16c40b741945a0a40f8bd707661e73/src/pybind/mgr/telemetry/module.py#L928-L930

except (KeyError, IndexError) as e:
-    self.log.error('Unable to get host from device with id "{}": {}'.format(devid, e))
+    self.log.exception('Unable to get host from device with id "{}": {}'.format(devid, e))
    continue

Related issues 1 (0 open — 1 closed)