Project

General

Profile

Actions

Bug #57405

closed

cephadm: tuned-profiles with dashes in name are automatically removed.

Added by Adam King over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
backport_processed
Backport:
quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

cephadm checks the name of the profiles on the host to see if they match what should be there via

for file in found_files:
            if '-cephadm-tuned-profile.conf' not in file:
                continue
            if not any(file.split('-')[0] in p.keys() for p in profiles):
                logger.info(f'Removing stray tuned profile file {file}')

the idea was since we always add "-cephadm-tuned-profile.conf" to the name we could split on the dashes to get the actual profile name, but this fails terribly if the names have dashes in them and we end up not properly matching the name and the profile is removed.


Related issues 1 (0 open1 closed)

Copied to Orchestrator - Backport #57525: quincy: cephadm: tuned-profiles with dashes in name are automatically removed.ResolvedAdam KingActions
Actions #1

Updated by Adam King over 1 year ago

  • Pull request ID set to 47936
Actions #2

Updated by Adam King over 1 year ago

  • Status changed from In Progress to Pending Backport
Actions #3

Updated by Backport Bot over 1 year ago

  • Copied to Backport #57525: quincy: cephadm: tuned-profiles with dashes in name are automatically removed. added
Actions #4

Updated by Backport Bot over 1 year ago

  • Tags set to backport_processed
Actions #5

Updated by Adam King over 1 year ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF