Bug #57032: cephadm: --no-overwrite flag for tuned-profile apply has no effect - Orchestrator - Ceph

Actions

Copy link

Bug #57032

closed

cephadm: --no-overwrite flag for tuned-profile apply has no effect

Added by Adam King over 1 year ago. Updated over 1 year ago.

Status:

Resolved

Priority:

Normal

Assignee:

Redouane Kachach Elhichou

Category:

Target version:

% Done:

Source:

Tags:

backport_processed

Backport:

quincy

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

47815

Crash signature (v1):

Crash signature (v2):

Description

It seems the actual effects of this flag were never implemented. It should probably either refuse to update a profile if a profile by the given name already exists (and return a message saying so) or possibly allow adding new settings, but not overwrite any existing settings if the new spec being applied also sets them. I lean towards the former, but something to think about.

Related issues 1 (0 open — 1 closed)