Bug #56969: has_bluestore_label() throws an error when the device_path is a path - ceph-volume - Ceph

Actions

Copy link

Bug #56969

closed

has_bluestore_label() throws an error when the device_path is a path

Added by Guillaume Abrioux over 1 year ago. Updated over 1 year ago.

Status:

Resolved

Priority:

Normal

Assignee:

Guillaume Abrioux

Target version:

% Done:

Source:

Tags:

backport_processed

Backport:

quincy,pacific

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

47361

Crash signature (v1):

Crash signature (v2):

Description

When we instantiate the Device class with a path instead of a block device, it throws an error like following

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.6/site-packages/ceph_volume/util/device.py", line 130, in __init__
    self._parse()
  File "/usr/lib/python3.6/site-packages/ceph_volume/util/device.py", line 233, in _parse
    self.ceph_device = disk.has_bluestore_label(self.path)
  File "/usr/lib/python3.6/site-packages/ceph_volume/util/disk.py", line 906, in has_bluestore_label
    with open(device_path, "rb") as fd:
IsADirectoryError: [Errno 21] Is a directory: '/var/lib/ceph/osd/ceph-0/'

Passing a path instead of a block device is valid, `simple scan` needs it.

Related issues 2 (0 open — 2 closed)