Actions
Bug #56950
closedOption --gpg-url return error on cephadm
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
cephadm
Target version:
-
% Done:
0%
Source:
Tags:
backport_processed
Backport:
quincy, pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
Seen on slack channel :
./cephadm add-repo --gpg-url https://download.ceph.com/keys/release.gpg --repo-url https://download.ceph.com --version 17.2.1
Traceback (most recent call last):
File "./cephadm", line 9281, in <module>
main()
File "./cephadm", line 9269, in main
r = ctx.func(ctx)
File "./cephadm", line 7819, in command_add_repo
pkg.add_repo()
File "./cephadm", line 7416, in add_repo
url, name = self.repo_gpgkey()
ValueError: too many values to unpack (expected 2)
Updated by Adam King over 1 year ago
- Backport changed from quincy to quincy, pacific
Updated by Adam King over 1 year ago
- Status changed from New to Pending Backport
- Pull request ID set to 47338
Updated by Backport Bot over 1 year ago
- Copied to Backport #56983: quincy: Option --gpg-url return error on cephadm added
Updated by Backport Bot over 1 year ago
- Copied to Backport #56984: pacific: Option --gpg-url return error on cephadm added
Updated by Mikel Nelson over 1 year ago
It appears that the key is written to disk as-is. The format of the downloaded key is usually an "armored" key (ascii encoded). However, apt is expecting the key to be "de-armored" (i.e. binary like).
The key needs to be "de-armored" as part of the download code.
However, there is also a secondary push currently in the newer version of linux to make the apt key stores safer: https://unix.stackexchange.com/questions/332672/how-to-add-a-third-party-repo-and-key-in-debian/582853#582853
This should probably be kept in mind for future cephadm releases.
Updated by Adam King over 1 year ago
- Status changed from Pending Backport to Resolved
Actions