Project

General

Profile

Actions

Bug #56416

closed

qa/cephfs: delete path from cmd args after use

Added by Rishabh Dave almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Method conduct_neg_test_for_write_caps() in qa/tasks/cephfs/caps_helper.py appends path to command arguments but doesn't delete it after execution. This will lead to 2 paths in second iteration which will lead to a bug in tests.

    def conduct_neg_test_for_write_caps(self, filepaths, mounts):
        cmdargs = ['echo', 'some random data', Raw('|'), 'tee']

        for mount in mounts:
            for path in filepaths:
                if path.find(mount.hostfs_mntpt) != -1:
                    cmdargs.append(path)
                    mount.negtestcmd(args=cmdargs, retval=1,
                                     errmsg='permission denied')

Removing path after the command has bee executed will fix the issue.

Actions #1

Updated by Rishabh Dave almost 2 years ago

  • Status changed from Fix Under Review to Resolved
Actions #2

Updated by Rishabh Dave almost 2 years ago

  • Pull request ID changed from 41778 to 46991
Actions

Also available in: Atom PDF