Project

General

Profile

Actions

Bug #56093

open

log_max_recent setting broken as of Nautilus

Added by Joshua Baergen almost 2 years ago. Updated over 1 year ago.

Status:
Pending Backport
Priority:
Normal
Category:
common
Target version:
-
% Done:

0%

Source:
Tags:
backport_processed
Backport:
octopus,pacific,quincy
Regression:
No
Severity:
3 - minor
Reviewed:

Description

We have an internal monitoring tool that connects to several dozen Ceph clusters that was exhibiting rapidly growing memory usage after upgrading it to use Nautilus libraries rather than Luminous ones. Inspecting /proc/<pid>/smaps for growing memory regions, dumping them via gdb, and then inspecting them using 'strings' revealed that they were full of log messages. We turned most logging off and the memory usage was much better controlled.

Digging through the code, I found that https://github.com/ceph/ceph/commit/a747aeac13daf3dba43343120659e802cb569f6b broke the log_max_recent option, meaning that non-daemons no longer have a reduced in-memory recent log entry buffer, increasing the memory usage of that buffer 20x for our usecase. This is probably not all that noticeable when connecting to one or two clusters, but it's very noticeable when connecting to dozens!

I have a fix for this that I've successfully tested on Nautilus. PR coming soon.


Related issues 3 (1 open2 closed)

Copied to Ceph - Backport #56635: pacific: log_max_recent setting broken as of NautilusResolvedKonstantin ShalyginActions
Copied to Ceph - Backport #56636: octopus: log_max_recent setting broken as of NautilusRejectedActions
Copied to Ceph - Backport #56637: quincy: log_max_recent setting broken as of NautilusIn ProgressKonstantin ShalyginActions
Actions #1

Updated by Joshua Baergen almost 2 years ago

PR: https://github.com/ceph/ceph/pull/46736

Looks like I should have set that when filing the tracker - I don't see how to modify that field after filing.

Actions #2

Updated by Ilya Dryomov almost 2 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Joshua Baergen
  • Pull request ID set to 46736
Actions #3

Updated by Ilya Dryomov almost 2 years ago

  • Backport set to octopus,pacific,quincy
Actions #4

Updated by Ilya Dryomov almost 2 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #5

Updated by Backport Bot almost 2 years ago

  • Copied to Backport #56635: pacific: log_max_recent setting broken as of Nautilus added
Actions #6

Updated by Backport Bot almost 2 years ago

  • Copied to Backport #56636: octopus: log_max_recent setting broken as of Nautilus added
Actions #7

Updated by Backport Bot almost 2 years ago

  • Copied to Backport #56637: quincy: log_max_recent setting broken as of Nautilus added
Actions #8

Updated by Backport Bot over 1 year ago

  • Tags set to backport_processed
Actions

Also available in: Atom PDF