Project

General

Profile

Bug #55796

[rbd-mirror] don't prune non-primary snapshot when restarting delta sync

Added by Ilya Dryomov about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
octopus,pacific,quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

When restarting interrupted sync (signified by the "end" non-primary snapshot with last_copied_object_number > 0), preserve the "start" non-primary snapshot until the sync is completed, like it would have been done had the sync not been interrupted. This would ensure that the same m_local_snap_id_start is passed to scan_remote_mirror_snapshots() and ultimately ImageCopyRequest state machine on restart as on initial start.

The current behavior goes back to https://github.com/ceph/ceph/commit/281af0de86b17244a2c64af80db0bf84de6d9819 where pruning of unnecessary non-primary snapshot was introduced, but that commit has proven to be buggy.


Related issues

Related to rbd - Subtask #44105: [rbd-mirror snapshot] clean-up unnecessary non-primary snapshots Resolved
Copied to rbd - Backport #55847: octopus: [rbd-mirror] don't prune non-primary snapshot when restarting delta sync Resolved
Copied to rbd - Backport #55848: quincy: [rbd-mirror] don't prune non-primary snapshot when restarting delta sync Resolved
Copied to rbd - Backport #55849: pacific: [rbd-mirror] don't prune non-primary snapshot when restarting delta sync Resolved

History

#1 Updated by Ilya Dryomov about 1 year ago

  • Related to Subtask #44105: [rbd-mirror snapshot] clean-up unnecessary non-primary snapshots added

#2 Updated by Ilya Dryomov about 1 year ago

  • Status changed from In Progress to Fix Under Review
  • Backport set to octopus,pacific,quincy
  • Pull request ID set to 46434

#3 Updated by Ilya Dryomov about 1 year ago

  • Status changed from Fix Under Review to Pending Backport

#4 Updated by Backport Bot about 1 year ago

  • Copied to Backport #55847: octopus: [rbd-mirror] don't prune non-primary snapshot when restarting delta sync added

#5 Updated by Backport Bot about 1 year ago

  • Copied to Backport #55848: quincy: [rbd-mirror] don't prune non-primary snapshot when restarting delta sync added

#6 Updated by Backport Bot about 1 year ago

  • Copied to Backport #55849: pacific: [rbd-mirror] don't prune non-primary snapshot when restarting delta sync added

#7 Updated by Ilya Dryomov about 1 year ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF