Project

General

Profile

Actions

Subtask #44105

closed

Tasks #41554: Implement snapshot-based mirroring

[rbd-mirror snapshot] clean-up unnecessary non-primary snapshots

Added by Jason Dillaman about 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jason Dillaman
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
octopus
Reviewed:
Affected Versions:
Pull request ID:

Description

When creating new non-primary snapshots, attempt to delete older non-primary snapshots that are no longer useful (i.e. fully synced, no peers, and the last mirror snapshot is kept). It might need to be a new "prune" state machine that runs during the "scan local snapshots" state of the replayer.


Related issues 2 (0 open2 closed)

Related to rbd - Bug #55796: [rbd-mirror] don't prune non-primary snapshot when restarting delta syncResolvedIlya Dryomov

Actions
Copied to rbd - Backport #45223: octopus: [rbd-mirror snapshot] clean-up unnecessary non-primary snapshotsResolvedNathan CutlerActions
Actions #1

Updated by Jason Dillaman about 4 years ago

  • Description updated (diff)
Actions #2

Updated by Jason Dillaman about 4 years ago

... also delete any non-primary snapshots that are incomplete w/ zero copy-progress. This could imply that the image state, object-map, etc are missing so we might as well start from scratch.

Actions #3

Updated by Jason Dillaman about 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Jason Dillaman
  • Backport set to octopus
Actions #4

Updated by Jason Dillaman about 4 years ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 34496
Actions #5

Updated by Mykola Golub about 4 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #6

Updated by Nathan Cutler almost 4 years ago

  • Copied to Backport #45223: octopus: [rbd-mirror snapshot] clean-up unnecessary non-primary snapshots added
Actions #7

Updated by Nathan Cutler almost 4 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions #8

Updated by Ilya Dryomov almost 2 years ago

  • Related to Bug #55796: [rbd-mirror] don't prune non-primary snapshot when restarting delta sync added
Actions

Also available in: Atom PDF