Bug #55564: s3select: -Wredundant-move warnings - rgw - Ceph

Actions

Copy link

Bug #55564

open

s3select: -Wredundant-move warnings

Added by Casey Bodley almost 2 years ago. Updated over 1 year ago.

Status:

In Progress

Priority:

Normal

Assignee:

Gal Salomon

Target version:

% Done:

Source:

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

[18/108] Building CXX object src/rgw/CMakeFiles/rgw_common.dir/rgw_s3select.cc.o
In file included from ceph/src/s3select/include/s3select_oper.h:16,
                 from ceph/src/s3select/include/s3select.h:12,
                 from ceph/src/rgw/rgw_s3select_private.h:35,
                 from ceph/src/rgw/rgw_s3select.cc:4:
ceph/src/s3select/include/s3select_parquet_intrf.h: In member function ‘arrow::Result<std::shared_ptr<arrow::Buffer> > arrow::io::ceph::ReadableFile::ReadableFileImpl::ReadBuffer(int64_t)’:
ceph/src/s3select/include/s3select_parquet_intrf.h:592:21: warning: redundant move in return statement [-Wredundant-move]
  592 |     return std::move(buffer);
      |            ~~~~~~~~~^~~~~~~~
ceph/src/s3select/include/s3select_parquet_intrf.h:592:21: note: remove ‘std::move’ call
ceph/src/s3select/include/s3select_parquet_intrf.h: In member function ‘arrow::Result<std::shared_ptr<arrow::Buffer> > arrow::io::ceph::ReadableFile::ReadableFileImpl::ReadBufferAt(int64_t, int64_t)’:
ceph/src/s3select/include/s3select_parquet_intrf.h:604:21: warning: redundant move in return statement [-Wredundant-move]
  604 |     return std::move(buffer);
      |            ~~~~~~~~~^~~~~~~~
ceph/src/s3select/include/s3select_parquet_intrf.h:604:21: note: remove ‘std::move’ call