Actions
Bug #55318
closedceph::mutex debugging is disabled in "make check" builds
% Done:
0%
Source:
Tags:
Backport:
quincy
Regression:
No
Severity:
3 - minor
Reviewed:
Description
Commit 403f1ec2888a ("cmake: make "WITH_CEPH_DEBUG_MUTEX" depend on CMAKE_BUILD_TYPE") made WITH_CEPH_DEBUG_MUTEX depend on build type being set to Debug, in CMakeLists.txt. However, if CMAKE_BUILD_TYPE isn't specified by the user, we may still set it to Debug later, in src/CMakeLists.txt, and in that case WITH_CEPH_DEBUG_MUTEX doesn't get enabled. The result is that
$ do_cmake.sh -DCMAKE_BUILD_TYPE=Debug ...
debug builds have mutex debugging enabled, while
$ do_cmake.sh ...
builds, which are supposed to be the same, don't. Jenkins builders don't pass -DCMAKE_BUILD_TYPE=Debug so that commit effectively turned off all ceph_mutex_is_locked* asserts in "make check" (which is where they are needed the most).
Actions