Bug #55318: ceph::mutex debugging is disabled in "make check" builds - devops - Ceph

Actions

Copy link

Bug #55318

closed

ceph::mutex debugging is disabled in "make check" builds

Added by Ilya Dryomov about 2 years ago. Updated almost 2 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Ilya Dryomov

Category:

Target version:

% Done:

Source:

Tags:

Backport:

quincy

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

45898

Crash signature (v1):

Crash signature (v2):

Description

Commit 403f1ec2888a ("cmake: make "WITH_CEPH_DEBUG_MUTEX" depend on CMAKE_BUILD_TYPE") made WITH_CEPH_DEBUG_MUTEX depend on build type being set to Debug, in CMakeLists.txt. However, if CMAKE_BUILD_TYPE isn't specified by the user, we may still set it to Debug later, in src/CMakeLists.txt, and in that case WITH_CEPH_DEBUG_MUTEX doesn't get enabled. The result is that

$ do_cmake.sh -DCMAKE_BUILD_TYPE=Debug ...

debug builds have mutex debugging enabled, while

$ do_cmake.sh ...

builds, which are supposed to be the same, don't. Jenkins builders don't pass -DCMAKE_BUILD_TYPE=Debug so that commit effectively turned off all ceph_mutex_is_locked* asserts in "make check" (which is where they are needed the most).

Related issues 2 (0 open — 2 closed)