Project

General

Profile

Actions

Bug #55059

open

debian/control file isn't installing all required deps?

Added by David Galloway about 2 years ago. Updated about 2 years ago.

Status:
New
Priority:
Normal
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

https://github.com/ceph/ceph/tree/master/monitoring/ceph-mixin seems to be causing some make check and API job failures. See attached.

Opening this ticket so we can have a discussion about where jsonnet should get installed.


Files

consoleText (581 KB) consoleText David Galloway, 03/25/2022 02:14 PM

Related issues 2 (0 open2 closed)

Blocked by Ceph - Bug #55091: debian: use build-profile to manage build deps ResolvedKefu Chai

Actions
Blocked by Dashboard - Bug #55060: mgr/dashboard: api test: ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.ResolvedErnesto Puerta

Actions
Actions #1

Updated by Ernesto Puerta about 2 years ago

The "make check" jsonnet error only seems to happen in this adami03 node.

The API tests one sounds like this one that Zack fixed a week ago:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
apache-libcloud 3.5.0 requires requests>=2.26.0, but you have requests 2.25.1 which is incompatible.
Successfully installed CherryPy-13.1.0 PyJWT-2.0.1 Routes-2.4.1 bcrypt-3.1.4 ceph-1.0.0 chardet-4.0.0 cheroot-8.6.0 idna-2.10 jaraco.functools-3.5.0 more-itertools-4.1.0 natsort-8.1.0 portend-3.1.0 pyopenssl-22.0.0 pytz-2022.1 repoze.lru-0.7 requests-2.25.1 tempora-5.0.1
/tmp/tmp.G1eoKAvDDf

Actions #2

Updated by Ernesto Puerta about 2 years ago

  • Related to Bug #55060: mgr/dashboard: api test: ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. added
Actions #3

Updated by David Galloway about 2 years ago

  • Project changed from Dashboard to CI
  • Subject changed from mgr/dashboard: test-jsonnet.sh: line 7: jsonnet: command not found to debian/control file isn't installing all required deps?
  • Assignee set to David Galloway

Okay, so, adami03 got installed and added as a builder this week. However, jsonnet is in debian/control and should be getting installed right here: https://github.com/ceph/ceph/blob/master/install-deps.sh#L364

Ah.. Got it. jsonnet got added here: https://github.com/ceph/ceph/commit/20f1d68f85cfb00777e7132134e9a8b131e2097b but with the <pkg.ceph.check>, condition.

Except Kefu's change to only pull in those deps during install-deps.sh didn't get backported. So the other slaves got jsonnet installed because they ran a PR targeted for master. But adami03 must not have yet so it didn't get jsonnet installed.

Actions #4

Updated by Arthur Outhenin-Chalandre about 2 years ago

Hi, it should be installed there https://github.com/ceph/ceph/blob/master/monitoring/ceph-mixin/CMakeLists.txt#L14-L15 which execute this script https://github.com/ceph/ceph/blob/master/monitoring/ceph-mixin/jsonnet-build.sh. The issue is that we need jsonnet v0.18.0 and both centos 8 and ubuntu have not yet updated jsonnet to that version unfortunately.

That being said I don't see the jsonnet-build task on the CI logs that you attached and `run-tox-grafana-check` doesn't exist in master anymore. So it look like an old version... On what branch this is running?

Actions #5

Updated by David Galloway about 2 years ago

Arthur Outhenin-Chalandre wrote:

Hi, it should be installed there https://github.com/ceph/ceph/blob/master/monitoring/ceph-mixin/CMakeLists.txt#L14-L15 which execute this script https://github.com/ceph/ceph/blob/master/monitoring/ceph-mixin/jsonnet-build.sh. The issue is that we need jsonnet v0.18.0 and both centos 8 and ubuntu have not yet updated jsonnet to that version unfortunately.

That being said I don't see the jsonnet-build task on the CI logs that you attached and `run-tox-grafana-check` doesn't exist in master anymore. So it look like an old version... On what branch this is running?

pacific. jsonnet-build.sh doesn't exist in that branch.

Actions #6

Updated by Arthur Outhenin-Chalandre about 2 years ago

David Galloway wrote:

Arthur Outhenin-Chalandre wrote:

Hi, it should be installed there https://github.com/ceph/ceph/blob/master/monitoring/ceph-mixin/CMakeLists.txt#L14-L15 which execute this script https://github.com/ceph/ceph/blob/master/monitoring/ceph-mixin/jsonnet-build.sh. The issue is that we need jsonnet v0.18.0 and both centos 8 and ubuntu have not yet updated jsonnet to that version unfortunately.

That being said I don't see the jsonnet-build task on the CI logs that you attached and `run-tox-grafana-check` doesn't exist in master anymore. So it look like an old version... On what branch this is running?

pacific. jsonnet-build.sh doesn't exist in that branch.

Ah ok sorry I didn't see your previous message in time as well. -- The jsonnet version requirement doesn't apply for the code in pacific right now so your backport should probably fix the issue.

Actions #7

Updated by Ernesto Puerta about 2 years ago

  • Blocked by Bug #55091: debian: use build-profile to manage build deps added
Actions #8

Updated by Ernesto Puerta about 2 years ago

  • Related to deleted (Bug #55060: mgr/dashboard: api test: ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.)
Actions #9

Updated by Ernesto Puerta about 2 years ago

  • Blocked by Bug #55060: mgr/dashboard: api test: ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. added
Actions #10

Updated by David Galloway about 2 years ago

@Ernesto, I don't think the issues you're linking are related. This issue is specifically about the debian package jsonnet getting installed during build time.

Actions

Also available in: Atom PDF