Project

General

Profile

Actions
Copy link

Bug #54354

open

dbstore: DB::objectmap leaks memory and is not thread-safe between DB instances

Added by Casey Bodley about 2 years ago. Updated about 2 years ago.

Status:
New
Priority:
Normal
Assignee:
Soumya Koduri
Target version:
-
% Done:

0%

Source:
Tags:
dbstore
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

what exactly is objectmap for? it only seems to be used for SQLiteDB::ListAllObjects() as a way to know which buckets to enumerate. but objectmap only caches the buckets that have been accessed since startup. why do we need a cache of buckets, instead of just traversing the 'buckets' table?

objectmap uses `std::map<std::string, ObjectOp*>` with raw (non-owning) pointers to ObjectOp instead of unique_ptr

objectmapDelete() does not free the ObjectOp. even if it did, SQLiteDB::ListAllObjects() makes a copy of the entire objectmap, so might try to read ObjectOps after they're freed

objectmap is a static variable, but the mutex protecting it is not static. this means objectmap is not thread-safe between instances of DB

Actions
Copy link
 #1

Updated by Soumya Koduri about 2 years ago

  • Assignee set to Soumya Koduri
Actions
Copy link

Also available in: Atom PDF