Actions
Bug #53453
closedcephadm: current agent lock setup allows extraneous agent daemon actions
% Done:
0%
Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Description
Specifically, since multiple threads can be trying to check the agents at the same time, even though the current setup stops them from reconfiguring the same agent in parallel, they can still reconfigure the same agent sequentially, because actually checking the old config/deps vs. the new ones is not done within the locked portion.
We really don't need multiple threads trying to check the agents at once. It would be better if the lock was at a bit of a higher level. This also means less time spent trying to acquire locks (one per the process of checking the agents vs. one per each agent we check).
Updated by Adam King over 2 years ago
- Status changed from New to In Progress
- Pull request ID set to 44031
Updated by Sebastian Wagner over 2 years ago
- Status changed from In Progress to Resolved
Actions