Actions
Bug #53425
closedceph-volume lvm list should not return "None"
Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
% Done:
0%
Source:
Tags:
Backport:
pacific,octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
When there is an empty value and ceph-volume is called with json output, we should get `""` instead of `"None"`.
See:
[root@f1c88a693032 /]# ceph-volume lvm list --format json
{
"0": [
{
"devices": [
"/dev/vdb"
],
"lv_name": "osd-block-706c4839-a8fe-426c-b19c-39836d1b9f68",
"lv_path": "/dev/ceph-ec14e5e9-437f-4b10-a488-06c708f64d63/osd-block-706c4839-a8fe-426c-b19c-39836d1b9f68",
"lv_size": "42945478656",
"lv_tags": "ceph.block_device=/dev/ceph-ec14e5e9-437f-4b10-a488-06c708f64d63/osd-block-706c4839-a8fe-426c-b19c-39836d1b9f68,ceph.block_uuid=6ELEUQ-Xpm4-c6pk-LXar-E599-9IPn-ryM4GY,ceph.cephx_lockbox_secret=,ceph.cluster_fsid=f20931eb-9336-4234-a5c7-b0b44ab8c07a,ceph.cluster_name=ceph,ceph.crush_device_class=None,ceph.encrypted=0,ceph.osd_fsid=706c4839-a8fe-426c-b19c-39836d1b9f68,ceph.osd_id=0,ceph.osdspec_affinity=,ceph.type=block,ceph.vdo=0",
"lv_uuid": "6ELEUQ-Xpm4-c6pk-LXar-E599-9IPn-ryM4GY",
"name": "osd-block-706c4839-a8fe-426c-b19c-39836d1b9f68",
"path": "/dev/ceph-ec14e5e9-437f-4b10-a488-06c708f64d63/osd-block-706c4839-a8fe-426c-b19c-39836d1b9f68",
"tags": {
"ceph.block_device": "/dev/ceph-ec14e5e9-437f-4b10-a488-06c708f64d63/osd-block-706c4839-a8fe-426c-b19c-39836d1b9f68",
"ceph.block_uuid": "6ELEUQ-Xpm4-c6pk-LXar-E599-9IPn-ryM4GY",
"ceph.cephx_lockbox_secret": "",
"ceph.cluster_fsid": "f20931eb-9336-4234-a5c7-b0b44ab8c07a",
"ceph.cluster_name": "ceph",
"ceph.crush_device_class": "None",
"ceph.encrypted": "0",
"ceph.osd_fsid": "706c4839-a8fe-426c-b19c-39836d1b9f68",
"ceph.osd_id": "0",
"ceph.osdspec_affinity": "",
"ceph.type": "block",
"ceph.vdo": "0"
},
"type": "block",
"vg_name": "ceph-ec14e5e9-437f-4b10-a488-06c708f64d63"
}
],
"1": [
{
"devices": [
"/dev/vdc"
],
"lv_name": "osd-block-4cb7e9ce-28a4-4b98-b67a-4c4786a64ce6",
"lv_path": "/dev/ceph-aaa8397a-04bf-4136-8ba6-6387e74c794a/osd-block-4cb7e9ce-28a4-4b98-b67a-4c4786a64ce6",
"lv_size": "42945478656",
"lv_tags": "ceph.block_device=/dev/ceph-aaa8397a-04bf-4136-8ba6-6387e74c794a/osd-block-4cb7e9ce-28a4-4b98-b67a-4c4786a64ce6,ceph.block_uuid=7H4C8z-zVQT-ADEa-w2TI-KG7M-SVlc-4cd76L,ceph.cephx_lockbox_secret=,ceph.cluster_fsid=f20931eb-9336-4234-a5c7-b0b44ab8c07a,ceph.cluster_name=ceph,ceph.crush_device_class=None,ceph.encrypted=0,ceph.osd_fsid=4cb7e9ce-28a4-4b98-b67a-4c4786a64ce6,ceph.osd_id=1,ceph.osdspec_affinity=,ceph.type=block,ceph.vdo=0",
"lv_uuid": "7H4C8z-zVQT-ADEa-w2TI-KG7M-SVlc-4cd76L",
"name": "osd-block-4cb7e9ce-28a4-4b98-b67a-4c4786a64ce6",
"path": "/dev/ceph-aaa8397a-04bf-4136-8ba6-6387e74c794a/osd-block-4cb7e9ce-28a4-4b98-b67a-4c4786a64ce6",
"tags": {
"ceph.block_device": "/dev/ceph-aaa8397a-04bf-4136-8ba6-6387e74c794a/osd-block-4cb7e9ce-28a4-4b98-b67a-4c4786a64ce6",
"ceph.block_uuid": "7H4C8z-zVQT-ADEa-w2TI-KG7M-SVlc-4cd76L",
"ceph.cephx_lockbox_secret": "",
"ceph.cluster_fsid": "f20931eb-9336-4234-a5c7-b0b44ab8c07a",
"ceph.cluster_name": "ceph",
"ceph.crush_device_class": "None",
"ceph.encrypted": "0",
"ceph.osd_fsid": "4cb7e9ce-28a4-4b98-b67a-4c4786a64ce6",
"ceph.osd_id": "1",
"ceph.osdspec_affinity": "",
"ceph.type": "block",
"ceph.vdo": "0"
},
"type": "block",
"vg_name": "ceph-aaa8397a-04bf-4136-8ba6-6387e74c794a"
}
],
"2": [
{
"devices": [
"/dev/vdd"
],
"lv_name": "osd-block-058f4926-6ee7-4165-9a55-db5a1fd22d2f",
"lv_path": "/dev/ceph-a8ae9f01-a440-4a0e-8e4d-592d3bce3a9d/osd-block-058f4926-6ee7-4165-9a55-db5a1fd22d2f",
"lv_size": "42945478656",
"lv_tags": "ceph.block_device=/dev/ceph-a8ae9f01-a440-4a0e-8e4d-592d3bce3a9d/osd-block-058f4926-6ee7-4165-9a55-db5a1fd22d2f,ceph.block_uuid=cr4xnI-h1sx-4DT3-ZC2N-0kI9-RtZF-Nkr3q1,ceph.cephx_lockbox_secret=,ceph.cluster_fsid=f20931eb-9336-4234-a5c7-b0b44ab8c07a,ceph.cluster_name=ceph,ceph.crush_device_class=None,ceph.encrypted=0,ceph.osd_fsid=058f4926-6ee7-4165-9a55-db5a1fd22d2f,ceph.osd_id=2,ceph.osdspec_affinity=,ceph.type=block,ceph.vdo=0",
"lv_uuid": "cr4xnI-h1sx-4DT3-ZC2N-0kI9-RtZF-Nkr3q1",
"name": "osd-block-058f4926-6ee7-4165-9a55-db5a1fd22d2f",
"path": "/dev/ceph-a8ae9f01-a440-4a0e-8e4d-592d3bce3a9d/osd-block-058f4926-6ee7-4165-9a55-db5a1fd22d2f",
"tags": {
"ceph.block_device": "/dev/ceph-a8ae9f01-a440-4a0e-8e4d-592d3bce3a9d/osd-block-058f4926-6ee7-4165-9a55-db5a1fd22d2f",
"ceph.block_uuid": "cr4xnI-h1sx-4DT3-ZC2N-0kI9-RtZF-Nkr3q1",
"ceph.cephx_lockbox_secret": "",
"ceph.cluster_fsid": "f20931eb-9336-4234-a5c7-b0b44ab8c07a",
"ceph.cluster_name": "ceph",
"ceph.crush_device_class": "None",
"ceph.encrypted": "0",
"ceph.osd_fsid": "058f4926-6ee7-4165-9a55-db5a1fd22d2f",
"ceph.osd_id": "2",
"ceph.osdspec_affinity": "",
"ceph.type": "block",
"ceph.vdo": "0"
},
"type": "block",
"vg_name": "ceph-a8ae9f01-a440-4a0e-8e4d-592d3bce3a9d"
}
]
}
Especially: "ceph.crush_device_class": "None",
Updated by Guillaume Abrioux over 2 years ago
- Status changed from New to Fix Under Review
- Pull request ID set to 44219
Updated by Guillaume Abrioux over 2 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Guillaume Abrioux over 2 years ago
- Copied to Backport #54007: pacific: ceph-volume lvm list should not return "None" added
Updated by Guillaume Abrioux over 2 years ago
- Copied to Backport #54008: octopus: ceph-volume lvm list should not return "None" added
Updated by Guillaume Abrioux about 2 years ago
- Status changed from Pending Backport to Resolved
Actions