Ceph

Hello everyone,

I have a crushmap type problem, so I want to ask community developers.
When the user customizes the bucket type, such as

int OSDMap::_build_crush_types(CrushWrapper& crush)
{
  crush.set_type_name(0, "osd");
  crush.set_type_name(1, "host");
  crush.set_type_name(2, "chassis");
  crush.set_type_name(3, "rack");
  crush.set_type_name(4, "row");
  crush.set_type_name(5, "pdu");
  crush.set_type_name(6, "pod");
  crush.set_type_name(7, "room");
  crush.set_type_name(8, "datacenter");
  crush.set_type_name(9, "zone");
  crush.set_type_name(10, "region");
  crush.set_type_name(11, "root");
  return 11;
}

Change to increase disk type between osd and host

int OSDMap::_build_crush_types(CrushWrapper& crush)
{
  crush.set_type_name(0, "osd");
  crush.set_type_name(1, "disk");
  crush.set_type_name(2, "host");
  crush.set_type_name(3, "chassis");
  crush.set_type_name(4, "rack");
  crush.set_type_name(5, "row");
  crush.set_type_name(6, "pdu");
  crush.set_type_name(7, "pod");
  crush.set_type_name(8, "room");
  crush.set_type_name(9, "datacenter");
  crush.set_type_name(10, "zone");
  crush.set_type_name(11, "region");
  crush.set_type_name(12, "root");
  return 11;
}

1. Export the crushmap through the ceph osd getcrushmap command line tool, modify the disk type between osd and host, and then import the method to take effect?
2. Is return 11 the 11 of crush.set_type_name(11, "root");?
3. If the code is modified, after adding the disk type between osd and host, should it be modified to return 12? Will this have a negative impact on the algorithm? Can the data be written correctly?