Project

General

Profile

Actions

Bug #52905

closed

cephadm gather-facts is returning zram* devices as a valid block device

Added by Paul Cuzner over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
cephadm (binary)
Target version:
% Done:

100%

Source:
Tags:
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Since zram are not usable devices for Ceph, gather-facts should not return them.

e.g.

  "flash_count": 1,
  "flash_list": [
    {
      "description": "Unknown Unknown (66.6GB)",
      "dev_name": "zram0",
      "disk_size_bytes": 66597158912,
      "model": "Unknown",
      "rev": "Unknown",
      "vendor": "Unknown",
      "wwid": "Unknown" 
    }

The zram device is shown, but also it's capacity is reported incorrectly!

The gather-facts code should be excluding zram.

A similar tracker for ceph-volume is https://tracker.ceph.com/issues/52904

Actions #1

Updated by Paul Cuzner over 2 years ago

  • % Done changed from 0 to 100
  • Pull request ID set to 43628
Actions #2

Updated by Paul Cuzner over 2 years ago

  • Status changed from New to Pending Backport

merged

Actions #3

Updated by Rob Haverkamp over 2 years ago

Paul Cuzner wrote:

merged

Hi Paul,

I've not done Ceph backports before, but I would like to help the community in this process and get some experience.
This tracker looks quite simple, and is tagged as low hanging fruit..

Do you mind if I try to backport this to the pacific branch? I think I can just follow the steps from https://github.com/ceph/ceph/blob/master/SubmittingPatches-backports.rst#the-backport-create-issue-script

and than open a PR targetting pacific with: https://github.com/ceph/ceph/blob/master/SubmittingPatches-backports.rst#the-backport-create-issue-script

Correct? Thanks!

Actions #4

Updated by Sebastian Wagner over 2 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF