Project

General

Profile

Actions
Copy link

Bug #5184

closed

libceph: create_singlethread_workqueue() error handling

Added by Alex Elder almost 11 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

In ceph_osdc_init() there are these lines of code:

        osdc->notify_wq = create_singlethread_workqueue("ceph-watch-notify");
        if (IS_ERR(osdc->notify_wq)) {

The problem is that create_singlethread_workqueue() returns a
null pointer on error, not a pointer-coded error. And I believe
IS_ERR() returns false for a null pointer.

Actions
Copy link
 #1

Updated by Anonymous almost 11 years ago

  • Priority changed from Normal to High
Actions
Copy link
 #2

Updated by Sage Weil almost 11 years ago

  • Project changed from Ceph to rbd
Actions
Copy link
 #3

Updated by Sage Weil over 10 years ago

  • Status changed from New to Resolved

dan carpenter fixed this

Actions
Copy link

Also available in: Atom PDF