Project

General

Profile

Actions

Bug #51328

closed

cephadm: `infer_fsid` should use fsid from ceph conf

Added by Michael Fritch almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Category:
cephadm (binary)
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

when a ceph.conf is present, but no daeamons deployed by cephadm exist:

bar:/ # cephadm shell
Using recent ceph image docker.io/ceph/ceph@sha256:54e95ae1e11404157d7b329d0bef866ebbb214b195a009e87aae4eba9d282949
Traceback (most recent call last):
  File "/sbin/cephadm", line 8230, in <module>
    main()
  File "/sbin/cephadm", line 8218, in main
    r = ctx.func(ctx)
  File "/sbin/cephadm", line 1699, in _infer_fsid
    return func(ctx)
  File "/sbin/cephadm", line 1731, in _infer_config
    return func(ctx)
  File "/sbin/cephadm", line 1759, in _infer_image
    return func(ctx)
  File "/sbin/cephadm", line 4484, in command_shell
    if fsid_conf_mismatch(ctx):
  File "/sbin/cephadm", line 4474, in fsid_conf_mismatch
    if 'fsid = ' + ctx.fsid != c.strip():
TypeError: can only concatenate str (not "NoneType") to str
Actions #1

Updated by Sebastian Wagner almost 3 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 42028
Actions #2

Updated by Sebastian Wagner over 2 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF