Project

General

Profile

Actions
Copy link

Bug #50102

closed

spec jsons that expect a list in a field dont verify that a list was actually given

Added by Daniel Pivonka about 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Daniel Pivonka
Category:
orchestrator
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
40552
Crash signature (v1):
Crash signature (v2):

Description

examples labels in a hostspec, networks in servicespec

[ceph: root@vm-00 /]# cat spec.yaml
service_type: host
addr: 192.168.0.123
hostname: vm-00
labels: MON

[ceph: root@vm-00 /]# ceph orch apply -i spec.yaml
Added host 'vm-00'

[ceph: root@vm-00 /]# ceph orch host ls f yaml
--
addr: 192.168.0.123
hostname: vm-00
labels:
- N
- O
- M
status: ''

[ceph: root@vm-00 /]# cat spec.yaml
service_type: rgw
service_id: india
placement:
hosts:
- vm-00
rgw_frontend_port: 8083
networks: 10.0.208.0/22

[ceph: root@vm-00 /]# ceph orch apply -i spec.yaml
Error EINVAL: Cannot parse network 1: '1' does not appear to be an IPv4 or IPv6 network

in both cases a list was expected but a string was given. in case of the hostspec no error was given and the data was stored incorrectly, in the case of the servicespec a misleading error was given

Actions
Copy link
 #1

Updated by Daniel Pivonka about 3 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 40552
Actions
Copy link
 #2

Updated by Ken Dreyer about 3 years ago

  • Backport set to pacific
Actions
Copy link
 #3

Updated by Kefu Chai about 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #4

Updated by Daniel Pivonka almost 3 years ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link

Also available in: Atom PDF