Project

General

Profile

Actions

Bug #49952

closed

run-promtool-unittests.sh fails with difference in floating point values in some tests

Added by Aashish Sharma about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
High
Category:
Monitoring
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Unit Testing: /home/rishabh/repos/ceph/test2/monitoring/prometheus/alerts/test_alerts.yml
9: FAILED:
9: expr: "abs(\n (\n (ceph_osd_numpg > 0) - on (job) group_left avg(ceph_osd_numpg > 0)\n by (job)\n ) / on (job) group_left avg(ceph_osd_numpg > 0) by (job)\n) * on(ceph_daemon) group_left(hostname) ceph_osd_metadata > 0.30\n", time: 5m,
9: exp:"{ceph_daemon=\"osd.1\", hostname=\"ceph\", instance=\"ceph:9283\", job=\"ceph\"} 3.691588785046729E-01"
9: got:"{ceph_daemon=\"osd.1\", hostname=\"ceph\", instance=\"ceph:9283\", job=\"ceph\"} 3.69158878504673E-01"
9: expr: "ceph_pool_stored / (ceph_pool_stored + ceph_pool_max_avail)\n* on(pool_id) group_right ceph_pool_metadata * 100 > 90\n", time: 1m,
9: exp:"{instance=\"ceph:9283\", job=\"ceph\", name=\"default.rgw.log\", pool_id=\"3\"} 9.999999999999059E+01"
9: got:"{instance=\"ceph:9283\", job=\"ceph\", name=\"default.rgw.log\", pool_id=\"3\"} 9.900990099009901E+01"
9:
1/1 Test #9: run-promtool-unittests ...........***Failed 0.25 sec

Actions #1

Updated by Aashish Sharma about 3 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 40395
Actions #2

Updated by Kefu Chai about 3 years ago

  • Status changed from Fix Under Review to Resolved
Actions #3

Updated by Ernesto Puerta about 3 years ago

Don't we need this backported to all branches where promtool is now running?

Actions #4

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 148 to Monitoring
Actions

Also available in: Atom PDF