Project

General

Profile

Actions
Copy link

Bug #49837

closed

mgr/pybind/snap_schedule: do not fail when no fs snapshots are available

Added by Sébastien Han about 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Sébastien Han
Category:
-
Target version:
Ceph - v17.0.0
% Done:

0%

Source:
Development
Tags:
Backport:
pacific,octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
mgr/snap_schedule
Labels (FS):
Pull request ID:
40157
Crash signature (v1):
Crash signature (v2):

Description

When calling the json output, we should not return any error but just an empty dict:

[root@rook-ceph-tools-78cdfd976c-xltx5 /]# ceph fs snap-schedule list / format=json
Error ENOENT: SnapSchedule for / not found
[root@rook-ceph-tools-78cdfd976c-xltx5 /]# echo $?
2

Related issues 2 (0 open — 2 closed)

Copied to CephFS - Backport #50538: pacific: mgr/pybind/snap_schedule: do not fail when no fs snapshots are availableResolvedSébastien HanActions
Copied to CephFS - Backport #50539: octopus: mgr/pybind/snap_schedule: do not fail when no fs snapshots are availableRejectedActions
Actions
Copy link
 #1

Updated by Sébastien Han about 3 years ago

  • Pull request ID set to 40157
Actions
Copy link
 #2

Updated by Patrick Donnelly about 3 years ago

  • Project changed from mgr to CephFS
  • Subject changed from snap_schedule: do not fail when no fs snapshots are available to mgr/pybind/snap_schedule: do not fail when no fs snapshots are available
  • Status changed from New to Fix Under Review
  • Target version set to v17.0.0
  • Source set to Development
  • Backport set to pacific,octopus
  • Component(FS) mgr/snap_schedule added
Actions
Copy link
 #3

Updated by Patrick Donnelly about 3 years ago

  • Assignee set to Sébastien Han
Actions
Copy link
 #4

Updated by Venky Shankar almost 3 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #5

Updated by Backport Bot almost 3 years ago

  • Copied to Backport #50538: pacific: mgr/pybind/snap_schedule: do not fail when no fs snapshots are available added
Actions
Copy link
 #6

Updated by Backport Bot almost 3 years ago

  • Copied to Backport #50539: octopus: mgr/pybind/snap_schedule: do not fail when no fs snapshots are available added
Actions
Copy link
 #7

Updated by Cory Snyder almost 3 years ago

@Patrick Donnelly - it seems that the snap_schedule module was added in Pacific, so I don't believe that this fix needs to be backported to Octopus. Can you just confirm so that I can close the Octopus backport tracker?

Actions
Copy link
 #8

Updated by Patrick Donnelly almost 3 years ago

Cory Snyder wrote:

@Patrick Donnelly - it seems that the snap_schedule module was added in Pacific, so I don't believe that this fix needs to be backported to Octopus. Can you just confirm so that I can close the Octopus backport tracker?

It was going to be backported but got cancelled: https://github.com/ceph/ceph/pull/37142

I'll reject the OCtopus backport, thanks.

Actions
Copy link
 #9

Updated by Loïc Dachary almost 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF