Project

General

Profile

Actions

Bug #49674

closed

monitoring unit.run files don't remove container first

Added by Sage Weil about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

the ceph daemon unit.run files look like

set -e
/usr/bin/install -d -m0770 -o 167 -g 167 /var/run/ceph/11a72f1d-1752-43ba-bc6a-84b856e3c1bb
# mon.eutow
! /usr/bin/docker rm -f ceph-11a72f1d-1752-43ba-bc6a-84b856e3c1bb-mon.eutow
/usr/bin/docker run --rm --net=host --ipc=host --privileged --group-add=disk --name ceph-11a72f1d-1752-43ba-bc6a-84b856e3c1bb-mon.eutow -e CONTAINER_IMAGE=docker.io/ceph/ceph:v15.2.6 -e NODE_NAME=eutow -v /var/run/ceph/11a72f1d-1752-43ba-bc6a-84b856e3c1bb:/var/run/ceph:z -v /var/log/ceph/11a72f1d-1752-43ba-bc6a-84b856e3c1bb:/var/log/ceph:z -v /var/lib/ceph/11a72f1d-1752-43ba-bc6a-84b856e3c1bb/crash:/var/lib/ceph/crash:z -v /var/lib/ceph/11a72f1d-1752-43ba-bc6a-84b856e3c1bb/mon.eutow:/var/lib/ceph/mon/ceph-eutow:z -v /var/lib/ceph/11a72f1d-1752-43ba-bc6a-84b856e3c1bb/mon.eutow/config:/etc/ceph/ceph.conf:z -v /dev:/dev -v /run/udev:/run/udev --entrypoint /usr/bin/ceph-mon docker.io/ceph/ceph:v15.2.6 -n mon.eutow -f --setuser ceph --setgroup ceph --default-log-to-file=false --default-log-to-stderr=true --default-log-stderr-prefix="debug " --default-mon-cluster-log-to-file=false --default-mon-cluster-log-to-stderr=true

notably, there is that docker rm -f ... line.

the monitoring unit.run files however look like

/usr/bin/docker run --rm --net=host --user 65534 --name ceph-11a72f1d-1752-43ba-bc6a-84b856e3c1bb-node-exporter.eutow -e CONTAINER_IMAGE=prom/node-exporter -e NODE_NAME=eutow -v /proc:/host/proc:ro -v /sys:/host/sys:ro -v /:/rootfs:ro prom/node-exporter --no-collector.timex

which can be problematic if the unit doesn't shut down cleanly for whatever reason

Actions

Also available in: Atom PDF