Project

General

Profile

Actions

Bug #49486

closed

qa: raw_cluster_cmd and raw_cluster_cmd_result loses command arguments passed

Added by Rishabh Dave about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The value of kwargs['args'] is overrided by value of args even when args is empty list/tuple. This happens for methods -

ceph_manager.CephManager.raw_cluster_cmd()
ceph_manager.CephManager.raw_cluster_cmd_result()
and vstart_runner.LocalCephManager.raw_cluster_cmd
and vstart_runner.LocalCephManager.raw_cluster_cmd_result

> /home/ceph/qa/tasks/cephfs/cephfs_test_case.py(141)setUp()
-> self.mds_cluster.mon_manager.raw_cluster_cmd(args="osd blocklist clear")
(Pdb) s
--Call--
> /home/ceph/qa/tasks/vstart_runner.py(999)raw_cluster_cmd()
-> def raw_cluster_cmd(self, *args, **kwargs):
(Pdb) n
> /home/ceph/qa/tasks/vstart_runner.py(1004)raw_cluster_cmd()
-> kwargs['args'] = args
(Pdb) p args
()
(Pdb) p kwargs['args']
'osd blocklist clear'
(Pdb) n
> /home/ceph/qa/tasks/vstart_runner.py(1005)raw_cluster_cmd()
-> if kwargs.get('stdout') is None:
(Pdb) p kwargs['args']
()
Actions #1

Updated by Rishabh Dave about 3 years ago

  • Subject changed from qa: CephManager.run_cluster loses command arguments passed to qa: raw_cluster_cmd and raw_cluster_cmd_result loses command arguments passed
  • Status changed from New to In Progress
Actions #2

Updated by Rishabh Dave about 3 years ago

  • Description updated (diff)
Actions #3

Updated by Rishabh Dave about 3 years ago

  • Pull request ID set to 39690
Actions #4

Updated by Kefu Chai about 3 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF