Project

General

Profile

Actions

Feature #47688

open

Github: configure the browser UI to automatically sign-off commits

Added by Anthony D'Atri over 3 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
common
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

In #37442 I commmitted several modest doc changes via the GH GUI. Along the way I missed an extraneous comma, that I should have removed.

@zdover23 alertly noticed this and removed it in a second commit. He quite understandably neglected to sign off his commit

I removed an unnecessary comma. As soon as this passes the five tests, it'll be ready to merge....and of course editing directly in the github browser window breaks the signed-off by check. Note to posterity and other Ceph admins: can we alter this behavior, so that these commits by default are signed? Can we avoid this kind of situation where a helpful, friendly edit ends up stalling a good PR?


Files

No data to display

Actions

Also available in: Atom PDF