Bug #47448: mgr/diskprediction_local: add unittest's to ensure correct python dependencies - mgr - Ceph

Actions

Copy link

Bug #47448

open

mgr/diskprediction_local: add unittest's to ensure correct python dependencies

Added by Karanraj Chauhan over 3 years ago. Updated over 3 years ago.

Status:

Fix Under Review

Priority:

Normal

Assignee:

Karanraj Chauhan

Category:

diskprediction_local

Target version:

% Done:

Source:

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

37513

Crash signature (v1):

Crash signature (v2):

Description

Currently, there are no unit tests that ensure that models in the diskprediction_local module work correctly. In some cases, users installed versions of scikit-learn that are do not comply with the requirements.txt in this module. As a result the ProphetStor models (default for this module) threw errors, because these were not compatible with the user installed version of scikit-learn. To prevent such issues in the future, we could add
1. unittest to ensure all models work without errors with versions as specified in the requirements.txt
2. unittest to ensure users install dependencies only as specified in the requirements.txt

Actions

Copy link

Updated by Yaarit Hatuka over 3 years ago

Assignee set to Karanraj Chauhan

Actions

Copy link

Updated by Karanraj Chauhan over 3 years ago

To address point 1 above, I'm thinking of adding python "unittest"s as done for other mgr modules such as dashboard, insights, etc.

For point 2 above, should it also just be a unittest inside the diskprediction_local module? Or is there some way of enforcing dependencies get installed just like in requirements.txt?

WDYT?

Actions

Copy link