Bug #47358
closed"ceph orch apply osd" chokes on valid service_spec.yml
0%
Description
The following service_spec.yml works fine for "ceph orch apply", but produces an error with "ceph orch apply osd"
master: ++ cat /root/service_spec_core.yml master: --- master: service_type: mon master: placement: master: hosts: master: - 'node1' master: - 'node2' master: - 'node3' master: --- master: service_type: mgr master: placement: master: hosts: master: - 'node1' master: - 'node2' master: - 'node3' master: --- master: service_type: osd master: service_id: sesdev_osd_deployment master: placement: master: hosts: master: - 'node1' master: - 'node2' master: - 'node3' master: data_devices: master: all: true master: ++ ceph orch apply osd -i /root/service_spec_core.yml --dry-run master: Error EINVAL: Failed to validate Drive Group: Didn't find Drivegroup specs
The error is:
master: ++ ceph orch apply osd -i /root/service_spec_core.yml master: Error EINVAL: Failed to validate Drive Group: Didn't find Drivegroup specs
A couple things:
First, it seems like the error message could be improved? A better wording might be:
"Your spec file includes services other than 'osd', but 'ceph orch apply osd' only works with service_type: osd"
Second, it seems that, by issuing "ceph orch apply osd", the user is explicitly stating that they want OSDs only to be deployed. In that case, the non-osd service stanzas could simply be ignored? Then the user would get an OSD deployment, as requested, instead of an error message.
Updated by Nathan Cutler over 3 years ago
- Subject changed from "ceph orch apply osd --dry-run" chokes on valid service_spec.yml to "ceph orch apply osd" chokes on valid service_spec.yml
Updated by Joshua Schmid over 3 years ago
- Assignee set to Joshua Schmid
First, it seems like the error message could be improved? A better wording might be: "Your spec file includes services other than 'osd', but 'ceph orch apply osd' only works with service_type: osd" Second, it seems that, by issuing "ceph orch apply osd", the user is explicitly stating that they want OSDs only to be deployed. In that case, the non-osd service stanzas could simply be ignored? Then the user would get an OSD deployment, as requested, instead of an error message.
Absolutely agree with both statements. Assigning to self
Updated by Sebastian Wagner over 3 years ago
MAybe we should just completely drop
ceph orch apply osd -i
and always recommend to use
ceph orch apply -i
Updated by Sebastian Wagner about 3 years ago
- Priority changed from Normal to Low
Updated by Sebastian Wagner about 3 years ago
- Status changed from New to In Progress
- Assignee set to Rafay Ghafoor
Updated by Sebastian Wagner almost 3 years ago
- Status changed from In Progress to New
- Assignee deleted (
Rafay Ghafoor)
Updated by Sebastian Wagner over 2 years ago
- Status changed from New to Resolved