Actions
Bug #47185
closedTypeError: _daemon_add_misc() got an unexpected keyword argument
Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
orchestrator
Target version:
-
% Done:
0%
Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Description
2020-08-28T10:01:45.393 INFO:teuthology.orchestra.run.smithi044:> sudo /home/ubuntu/cephtest/cephadm --image quay.ceph.io/ceph-ci/ceph:6258ea1dcfe72989baca3f3155cff7e60f2b9ac9 shell -c /etc/ceph/ceph.conf -k /etc/ceph/ceph.client.admin.keyring --fsid 19d8afaa-e915-11ea-a074-001a4aab830c -- ceph orch daemon add mon 'smithi044:[v2:172.21.15.44:3301,v1:172.21.15.44:6790]=c' 2020-08-28T10:01:47.113 INFO:teuthology.orchestra.run.smithi044.stderr:Error EINVAL: Traceback (most recent call last): 2020-08-28T10:01:47.114 INFO:teuthology.orchestra.run.smithi044.stderr: File "/usr/share/ceph/mgr/mgr_module.py", line 1191, in _handle_command 2020-08-28T10:01:47.114 INFO:teuthology.orchestra.run.smithi044.stderr: return self.handle_command(inbuf, cmd) 2020-08-28T10:01:47.114 INFO:teuthology.orchestra.run.smithi044.stderr: File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 141, in handle_command 2020-08-28T10:01:47.114 INFO:teuthology.orchestra.run.smithi044.stderr: return dispatch[cmd['prefix']].call(self, cmd, inbuf) 2020-08-28T10:01:47.115 INFO:teuthology.orchestra.run.smithi044.stderr: File "/usr/share/ceph/mgr/mgr_module.py", line 328, in call 2020-08-28T10:01:47.115 INFO:teuthology.orchestra.run.smithi044.stderr: return self.func(mgr, **kwargs) 2020-08-28T10:01:47.115 INFO:teuthology.orchestra.run.smithi044.stderr: File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 103, in <lambda> 2020-08-28T10:01:47.115 INFO:teuthology.orchestra.run.smithi044.stderr: wrapper_copy = lambda *l_args, **l_kwargs: wrapper(*l_args, **l_kwargs) 2020-08-28T10:01:47.115 INFO:teuthology.orchestra.run.smithi044.stderr: File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 92, in wrapper 2020-08-28T10:01:47.116 INFO:teuthology.orchestra.run.smithi044.stderr: return func(*args, **kwargs) 2020-08-28T10:01:47.116 INFO:teuthology.orchestra.run.smithi044.stderr:TypeError: _daemon_add_misc() got an unexpected keyword argument 'smithi044:[v2:172.21.15.44:3301,v1:172.21.15.44:6790]' 2020-08-28T10:01:47.116 INFO:teuthology.orchestra.run.smithi044.stderr:
Possible cause: https://github.com/ceph/ceph-ci/commit/ee9dea6cbf9879208ca88786e7f3a944d479e9ed
Updated by Kefu Chai over 3 years ago
- Priority changed from Normal to Urgent
urgent, because almost all cephadm tests are failing: https://pulpito.ceph.com/kchai-2020-08-29_13:54:19-rados-wip-kefu-testing-2020-08-29-1945-distro-basic-smithi/
Updated by Kefu Chai over 3 years ago
offending PR https://github.com/ceph/ceph/pull/29489
Updated by Kefu Chai over 3 years ago
ceph orch daemon add mon 'smithi044:[v2:172.21.15.44:3301,v1:172.21.15.44:6790]=c'
is parsed into a dict of
{"daemon_type": "mon",
"placement": "smithi044:[v2:172.21.15.44:3301,v1:172.21.15.44:6790]=c}"
while CLICommand.call() splits "smithi044:[v2:172.21.15.44:3301,v1:172.21.15.44:6790]=c}" into
{"smithi044:[v2:172.21.15.44:3301,v1:172.21.15.44:6790]": "c"}
hence the failure
Jan, what's the use case of passing key-worded arguments? i think the "ceph" cli should have already done the parsing job which always sends the properly parsed dict to ceph daemons according to the command spec.
Updated by Kefu Chai over 3 years ago
also,
In [1]: "hello".split('=') Out[1]: ['hello']
does not throw.
Updated by Sebastian Wagner over 3 years ago
- Status changed from New to Resolved
Actions