simple (ceph-disk style) OSDs adopted by cephadm must not call `ceph-volume lvm activate`
The unit files created when adopting OSDs include a few
chown calls to handle simple (ceph-disk style) OSDs, and also include a call to
ceph-volume lvm activate, to handle LVM OSDs. The problem here is that
ceph-volume lvm activate fails for simple OSDs, and this in turn causes the OSD to not start. Last time I was working on this (see https://tracker.ceph.com/issues/45129), I didn't hit this problem, but something must have changed in the meantime. Whether that's a new systemd version, or a slightly different error handling path, I'm not sure, but the point is it would be best if we only generated exactly the correct commands, depending on the type of OSD, rather than including both the
chown and the
ceph-volume lvm activate calls in all cases.
(This issue was originally reported downstream as https://bugzilla.suse.com/show_bug.cgi?id=1174594)