Project

General

Profile

Actions

Bug #46769

open

qa: Refactor cephfs creation/removal code.

Added by Kotresh Hiremath Ravishankar almost 4 years ago. Updated over 3 years ago.

Status:
Fix Under Review
Priority:
Normal
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
qa-suite
Labels (FS):
qa
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The 'CephFSTestCase' class creates the filesystem based on
'REQUIRE_FILESYSTEM' flag in 'setUp' but the corresponding
'tearDown' function doesn't cleanup the same.

The 'setUp' routine also cleans up stale filesystems if present.
So the filesystem created for a test case, doesn't get cleaned
up during tearDown of same test case but instead gets cleaned
up with the beginning of next test case. Though there is no
functional impact, cleaning it up in tearDown is neat.

There is a duplicate dead code of fs creation/removal code in
test_volumes.py. That also can be removed.

Actions

Also available in: Atom PDF