Project

General

Profile

Actions

Bug #46542

closed

mgr/dashboard: Documented dashboard instance ssl certificate functionality not implemented

Added by Gregor Krmelj almost 4 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
pacific,octopus, nautilus
Regression:
No
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The documentation states that it is possible to set a different SSL certificate/key for each manager instance (https://docs.ceph.com/docs/octopus/mgr/dashboard/#ssl-tls-support) using:

$ ceph dashboard set-ssl-certificate $name -i dashboard.crt
$ ceph dashboard set-ssl-certificate-key $name -i dashboard.key

This functionality is not actually implemented. Looking at the code (https://github.com/ceph/ceph/blob/v15.2.4/src/pybind/mgr/dashboard/module.py#L157) the issue is that the dashboard is only reading the module's KV store setting but not the localized store (the one for the "instance").

Replacing `get_store` in lines 157 and 166 (https://github.com/ceph/ceph/blob/v15.2.4/src/pybind/mgr/dashboard/module.py#L157-L166) with `get_localized_store` and restarting the dashboard (`ceph mgr module disable dashboard && ceph mgr module enable dashboard`) pulls the actual instance certificate set as per instructions in the docs.

Ceph cluster version: 15.2.4
Ceph installation method: cephadm


Related issues 3 (0 open3 closed)

Copied to Dashboard - Backport #49702: pacific: mgr/dashboard: Documented dashboard instance ssl certificate functionality not implementedResolvedAvan ThakkarActions
Copied to Dashboard - Backport #49703: octopus: mgr/dashboard: Documented dashboard instance ssl certificate functionality not implementedResolvedAvan ThakkarActions
Copied to Dashboard - Backport #49704: nautilus: mgr/dashboard: Documented dashboard instance ssl certificate functionality not implementedResolvedAvan ThakkarActions
Actions #1

Updated by Sebastian Wagner almost 4 years ago

  • Project changed from Ceph to mgr
  • Category set to 146
Actions #2

Updated by Avan Thakkar about 3 years ago

Thanks Gregor Krmelj for pointing it out. I've created the PR with the change you suggested.

Actions #3

Updated by Avan Thakkar about 3 years ago

  • Subject changed from Documented dashboard instance ssl certificate functionality not implemented to mgr/dashboard: Documented dashboard instance ssl certificate functionality not implemented
  • Status changed from New to In Progress
  • Assignee set to Avan Thakkar
  • Backport set to octopus
Actions #4

Updated by Avan Thakkar about 3 years ago

  • Category deleted (146)
  • Assignee changed from Avan Thakkar to Yehuda Sadeh
  • Severity deleted (2 - major)
  • Pull request ID set to 39503
Actions #5

Updated by Avan Thakkar about 3 years ago

  • Assignee changed from Yehuda Sadeh to Avan Thakkar
Actions #6

Updated by Ernesto Puerta about 3 years ago

  • Backport changed from octopus to pacific,octopus, nautilus
Actions #7

Updated by Ernesto Puerta about 3 years ago

  • Status changed from In Progress to Pending Backport
Actions #8

Updated by Backport Bot about 3 years ago

  • Copied to Backport #49702: pacific: mgr/dashboard: Documented dashboard instance ssl certificate functionality not implemented added
Actions #9

Updated by Backport Bot about 3 years ago

  • Copied to Backport #49703: octopus: mgr/dashboard: Documented dashboard instance ssl certificate functionality not implemented added
Actions #10

Updated by Backport Bot about 3 years ago

  • Copied to Backport #49704: nautilus: mgr/dashboard: Documented dashboard instance ssl certificate functionality not implemented added
Actions #11

Updated by Ernesto Puerta about 3 years ago

  • Status changed from Pending Backport to Resolved
Actions #12

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
Actions

Also available in: Atom PDF