Project

General

Profile

Actions

Bug #46406

closed

pybind/mgr/balancer: should use "==" and "!=" for comparing strings

Added by Kefu Chai almost 4 years ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
balancer module
Target version:
-
% Done:

100%

Source:
Q/A
Tags:
Backport:
nautilus, octopus
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

"is" is just not correct. as we cannot guarantee that two strings with the same value share the same identity.


Related issues 2 (0 open2 closed)

Copied to RADOS - Backport #46460: octopus: pybind/mgr/balancer: should use "==" and "!=" for comparing stringsResolvedNathan CutlerActions
Copied to RADOS - Backport #46461: nautilus: pybind/mgr/balancer: should use "==" and "!=" for comparing stringsResolvedNathan CutlerActions
Actions

Also available in: Atom PDF