Project

General

Profile

Actions
Copy link

Bug #46027

closed

bufferlist c_str() sometimes clears assignment to mempool

Added by Adam Kupczyk almost 4 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Adam Kupczyk
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
nautilus, octopus
Regression:
No
Severity:
4 - irritation
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
35584
Crash signature (v1):
Crash signature (v2):

Description

Sometimes c_str() needs to rebuild underlying buffer::raw.
It that case original assignment to mempool is lost.

Related issues 2 (0 open — 2 closed)

Copied to bluestore - Backport #48193: nautilus: bufferlist c_str() sometimes clears assignment to mempoolResolvedNathan CutlerActions
Copied to bluestore - Backport #48194: octopus: bufferlist c_str() sometimes clears assignment to mempoolResolvedNathan CutlerActions
Actions
Copy link
 #1

Updated by Adam Kupczyk almost 4 years ago

  • Assignee set to Adam Kupczyk
Actions
Copy link
 #3

Updated by Kefu Chai almost 4 years ago

  • Status changed from New to Resolved
  • Pull request ID set to 35584
Actions
Copy link
 #4

Updated by Zac Medico over 3 years ago

It could be beneficial to backport this fix to octypus and nautilus. I suspect that it fixes a rebuild leak to the buffer_anon mempool in the ObjectModDesc trim_bl method shown here:

https://github.com/ceph/ceph/commit/62fd382fbf10f2b78946426644d445549a7ebed1

Actions
Copy link
 #5

Updated by Nathan Cutler over 3 years ago

  • Status changed from Resolved to Pending Backport
  • Backport set to nautilus, octopus
Actions
Copy link
 #6

Updated by Nathan Cutler over 3 years ago

  • Copied to Backport #48193: nautilus: bufferlist c_str() sometimes clears assignment to mempool added
Actions
Copy link
 #7

Updated by Nathan Cutler over 3 years ago

  • Copied to Backport #48194: octopus: bufferlist c_str() sometimes clears assignment to mempool added
Actions
Copy link
 #8

Updated by Nathan Cutler about 3 years ago

  • Status changed from Pending Backport to Resolved

While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".

Actions
Copy link

Also available in: Atom PDF