Bug #45724
check-host should not fail using fqdn or not that hard
% Done:
0%
Source:
Tags:
low-hanging-fruit
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Description
I would suggest either identify that it's an FQDN or answer "Host not found. Use 'ceph orch host ls' to see all managed hosts."
# ceph cephadm check-host node3.ses7.com Error EINVAL: Traceback (most recent call last): File "/usr/share/ceph/mgr/mgr_module.py", line 1153, in _handle_command return self.handle_command(inbuf, cmd) File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 110, in handle_command return dispatch[cmd['prefix']].call(self, cmd, inbuf) File "/usr/share/ceph/mgr/mgr_module.py", line 308, in call return self.func(mgr, **kwargs) File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 72, in <lambda> wrapper_copy = lambda *l_args, **l_kwargs: wrapper(*l_args, **l_kwargs) File "/usr/share/ceph/mgr/orchestrator/_interface.py", line 63, in wrapper return func(*args, **kwargs) File "/usr/share/ceph/mgr/cephadm/module.py", line 1482, in check_host error_ok=True, no_fsid=True) File "/usr/share/ceph/mgr/cephadm/module.py", line 1569, in _run_cephadm conn, connr = self._get_connection(addr) File "/usr/share/ceph/mgr/cephadm/module.py", line 1521, in _get_connection n = self.ssh_user + '@' + host TypeError: must be str, not NoneType
History
#1 Updated by Sebastian Wagner almost 4 years ago
- Priority changed from Normal to High
- Tags set to low-hanging-fruit
#2 Updated by Sebastian Wagner over 3 years ago
- Assignee set to Adam King
#3 Updated by Adam King over 3 years ago
- Status changed from New to Fix Under Review
- Pull request ID set to 35862
#4 Updated by Adam King over 3 years ago
- Status changed from Fix Under Review to Resolved
#5 Updated by Sebastian Wagner over 3 years ago
- Target version changed from v15.2.2 to v15.2.4