Project

General

Profile

Bug #45294

cephdam: rgw realm/zone could contain 'hostname'

Added by Michael Fritch 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Category:
cephadm
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

A 'hostname' like sub-string could be provided as a realm/zone :

$ ceph orch apply rgw realm host1 --placement host1
Scheduled rgw.realm.host1 update...

Creating this DaemonDesription:

$ ceph orch ps --daemon-type rgw --format yaml
container_id: a4301f77e336
container_image_id: 7bb50d3c5c9afcb8d68417890cae4ac782cf68c9b48e2879bc7e610cc7e2d45c
container_image_name: docker.io/ceph/daemon-base:latest-master-devel
created: '2020-04-27T18:14:11.074853'
daemon_id: realm.host1.host1.brcvkx
daemon_type: rgw
hostname: host1
last_refresh: '2020-04-27T18:14:31.272693'
started: '2020-04-27T18:14:11.205837'
status: 1
status_desc: running
version: 16.0.0-899-g18734af

But breaks the `orch ls` command:

$ ceph orch ls rgw
Error EINVAL: Traceback (most recent call last):
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/mgr_module.py", line 1157, in _handle_command
    return self.handle_command(inbuf, cmd)
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/orchestrator/_interface.py", line 110, in handle_command
    return dispatch[cmd['prefix']].call(self, cmd, inbuf)
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/mgr_module.py", line 308, in call
    return self.func(mgr, **kwargs)
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/orchestrator/_interface.py", line 72, in <lambda>
    wrapper_copy = lambda *l_args, **l_kwargs: wrapper(*l_args, **l_kwargs)
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/orchestrator/_interface.py", line 63, in wrapper
    return func(*args, **kwargs)
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/orchestrator/module.py", line 334, in _list_services
    completion = self.describe_service(service_type,
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/orchestrator/_interface.py", line 1542, in inner
    completion = self._oremote(method_name, args, kwargs)
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/orchestrator/_interface.py", line 1614, in _oremote
    return mgr.remote(o, meth, *args, **kwargs)
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/mgr_module.py", line 1518, in remote
    return self._ceph_dispatch_remote(module_name, method_name,
RuntimeError: Remote method threw exception: Traceback (most recent call last):
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/cephadm/module.py", line 561, in wrapper
    return AsyncCompletion(value=f(*args, **kwargs), name=f.__name__)
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/cephadm/module.py", line 1822, in describe_service
    n: str = dd.service_name()
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/orchestrator/_interface.py", line 1312, in service_name
    return f'{self.daemon_type}.{self.service_id()}'
  File "/root/src/github.com/mgfritch/ceph/src/pybind/mgr/orchestrator/_interface.py", line 1297, in service_id
    pre, post_ = self.daemon_id.split(self.hostname)
ValueError: too many values to unpack (expected 2)

Similar to this tracker:

https://tracker.ceph.com/issues/44934

History

#1 Updated by Michael Fritch 3 months ago

  • Pull request ID set to 34778

#2 Updated by Michael Fritch 3 months ago

  • Status changed from New to Fix Under Review

#3 Updated by Sebastian Wagner 2 months ago

  • Status changed from Fix Under Review to Pending Backport

#4 Updated by Sebastian Wagner about 1 month ago

  • Status changed from Pending Backport to Resolved
  • Target version set to v15.2.4

Also available in: Atom PDF