Bug #44938
closed
[rbd-mirror] tx-only peer from heartbeat can race w/ CLI
Added by Jason Dillaman about 4 years ago.
Updated over 3 years ago.
- Status changed from In Progress to Fix Under Review
- Pull request ID set to 34422
- Status changed from Fix Under Review to Pending Backport
- Copied to Backport #45036: octopus: [rbd-mirror] tx-only peer from heartbeat can race w/ CLI added
- Status changed from Pending Backport to Fix Under Review
- Status changed from Fix Under Review to Pending Backport
- Status changed from Pending Backport to Resolved
While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".
- Status changed from Resolved to Pending Backport
@Jason Borden The octopus backport PR for this issue was already merged. Is it missing something?
Yes, see comment #7. It has an additional fix that we should backport. I'm just re-using these tracker tickets instead of opening new ones.
- Status changed from Pending Backport to Resolved
While running with --resolve-parent, the script "backport-create-issue" noticed that all backports of this issue are in status "Resolved" or "Rejected".
Jason Dillaman wrote:
Yes, see comment #7. It has an additional fix that we should backport. I'm just re-using these tracker tickets instead of opening new ones.
I believe both commits are now in octopus:
commit f93516d78734740c30c5532e5032be1893004bb1
Author: Mykola Golub <mgolub@suse.com>
Date: Sat Apr 25 08:36:25 2020 +0100
qa/workunits/rbd: retry the addition of a mirror pool peer
fb4311f5 has fixed this for setup, but "remove mirroring pool"
test needs fixing too.
Fixes: https://tracker.ceph.com/issues/44938
Signed-off-by: Mykola Golub <mgolub@suse.com>
(cherry picked from commit 7eced158a9a3c47cc408b35219b4428e97e018fb)
commit 4644cd663de27bd19b07eb8dca0153032060694b
Author: Jason Dillaman <dillaman@redhat.com>
Date: Wed Apr 15 16:27:07 2020 -0400
qa/workunits/rbd: retry the addition of a mirror pool peer
We might race with the remote rbd-mirror daemon creating a
tx-only peer when adding a new peer. Therefore, delete the
tx-only peer and attempt to re-create it.
Fixes: https://tracker.ceph.com/issues/44938
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit fb4311f597a98b6870d7895e6403fb32356bfbe9)
Also available in: Atom
PDF