Project

General

Profile

Actions

Feature #449

closed

Support "secretfile" as an option

Added by Wido den Hollander over 13 years ago. Updated over 13 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:

Description

I just tried:

echo "[2001:16f8:10:2::c3c3:3f9b] name=admin,secretfile=/etc/ceph/secret rbd alpha" > /sys/class/rbd/add

That resulted in a kernel panic of the machine (latest master of the ceph-client).

I checked the source and found in linux/ceph/auth.h that only secret is supported ( struct ceph_auth_client ).

It would be useful to support secretfile, this prevents your key showing up in your bash history.

Actions #1

Updated by Sage Weil over 13 years ago

  • Assignee set to Yehuda Sadeh

Yehuda, can you look at the crashing part?

secretfile won't work here, btw, since the kernel can't read files. To the item in bash history you just need to use a helper program of some sort. At some point we could make the rbd tool do some of this.

Actions #2

Updated by Yehuda Sadeh over 13 years ago

The crashing part is fixed with commit:95ce358e10a20b31ad98724bf323e707e2b6ce86.

Actions #3

Updated by Sage Weil over 13 years ago

  • Status changed from New to Resolved

ok closing this one out. we should consider whether it makes sense in the future for the rbd (or some other) tool to help with the rbd dev setup (/sys/class/rbd).

Actions #4

Updated by Sage Weil over 13 years ago

  • Project changed from 3 to Linux kernel client
  • Category deleted (7)
Actions

Also available in: Atom PDF