Bug #44860: mgr/dashbord: keep state for clicked top level menu - Dashboard - Ceph

Actions

Copy link

Bug #44860

open

mgr/dashbord: keep state for clicked top level menu

Added by Ernesto Puerta about 4 years ago. Updated 6 months ago.

Status:

Fix Under Review

Priority:

Normal

Assignee:

Ivo Almeida

Category:

Target version:

% Done:

100%

Source:

Tags:

low-hanging-fruit

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

Right now Angular, keeps the highlighter vertical menu aligned to the current page, however, the expandable top-level menu is not properly kept. That means that if a page is refreshed, or browser navigation goes back, the expanded vertical menu is not kept (all top-level menu items are collapsed).

While a general state management solution would be desirable, this specific issue can be easily fixed with an ad-hoc solution (history.pushState). Given the vertical menu is clicked often, this would mean a noticeable UI improvement.

Files

Download all files

collapsed_logs_page.png (36.7 KB) collapsed_logs_page.png		Ernesto Puerta, 04/05/2022 01:00 PM
expanded_logs_page.png (61.1 KB) expanded_logs_page.png		Ernesto Puerta, 04/05/2022 01:00 PM

Actions

Copy link

Updated by Ernesto Puerta about 3 years ago

Translation missing: en.field_tag_list set to low-hanging-fruit

Actions

Copy link

Updated by Ernesto Puerta about 3 years ago

Project changed from mgr to Dashboard
Category changed from 165 to UI

Actions

Copy link

Updated by Plaban Kumar Mondal about 2 years ago

Is this issue still exists? Because when I am refreshing the browser, the expanded vertical menu(which contains Dashboard, Cluster, Pools, Block, NFS, File Systems, Object Gateway) is still expanded.

Actions

Copy link Download all files

Updated by Ernesto Puerta about 2 years ago

File expanded_logs_page.png expanded_logs_page.png added
File collapsed_logs_page.png collapsed_logs_page.png added

It's still there.

For example you can reproduce this by either directly pasting a URL to your browsers navigation (e.g.: https://<hostname>:<port>/#/logs).

That will lead you to the Logs page, and the "Cluster" high-level menu item will be highlighted, but not expanded:

Instead, it should be displayed expanded:

The changes should probably be made to the navigation component, basically ensuring that if a nested menu item is active, the parent item is expanded (besides, that wouldn't require any kind of status management, which simplifies the fix).

Actions

Copy link

Updated by Plaban Kumar Mondal about 2 years ago

I want to give it a try.

Actions

Copy link

Updated by Plaban Kumar Mondal about 2 years ago

Can someone assign this to me?

Actions

Copy link

Updated by Laura Flores about 2 years ago

Hey Plaban, you have to be added to the Devels team in order to be assigned. While we work on that, go ahead and take on this issue. Leaving a comment here is enough to let others know you are working on it.

Actions

Copy link