Project

General

Profile

Bug #44860

mgr/dashbord: keep state for clicked top level menu

Added by Ernesto Puerta over 3 years ago. Updated about 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
-
% Done:

100%

Source:
Tags:
low-hanging-fruit
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Tags:
low-hanging-fruit

Description

Right now Angular, keeps the highlighter vertical menu aligned to the current page, however, the expandable top-level menu is not properly kept. That means that if a page is refreshed, or browser navigation goes back, the expanded vertical menu is not kept (all top-level menu items are collapsed).

While a general state management solution would be desirable, this specific issue can be easily fixed with an ad-hoc solution (history.pushState). Given the vertical menu is clicked often, this would mean a noticeable UI improvement.

collapsed_logs_page.png View (36.7 KB) Ernesto Puerta, 04/05/2022 01:00 PM

expanded_logs_page.png View (61.1 KB) Ernesto Puerta, 04/05/2022 01:00 PM

History

#1 Updated by Ernesto Puerta over 2 years ago

  • Tags set to low-hanging-fruit

#2 Updated by Ernesto Puerta over 2 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 165 to UI

#3 Updated by Plaban Kumar Mondal over 1 year ago

Is this issue still exists? Because when I am refreshing the browser, the expanded vertical menu(which contains Dashboard, Cluster, Pools, Block, NFS, File Systems, Object Gateway) is still expanded.

#4 Updated by Ernesto Puerta over 1 year ago

It's still there.

For example you can reproduce this by either directly pasting a URL to your browsers navigation (e.g.: https://<hostname>:<port>/#/logs).

That will lead you to the Logs page, and the "Cluster" high-level menu item will be highlighted, but not expanded:

Instead, it should be displayed expanded:

The changes should probably be made to the navigation component, basically ensuring that if a nested menu item is active, the parent item is expanded (besides, that wouldn't require any kind of status management, which simplifies the fix).

#5 Updated by Plaban Kumar Mondal over 1 year ago

I want to give it a try.

#6 Updated by Plaban Kumar Mondal over 1 year ago

Can someone assign this to me?

#7 Updated by Laura Flores over 1 year ago

Hey Plaban, you have to be added to the Devels team in order to be assigned. While we work on that, go ahead and take on this issue. Leaving a comment here is enough to let others know you are working on it.

#8 Updated by Plaban Kumar Mondal over 1 year ago

  • Assignee set to Plaban Kumar Mondal

#9 Updated by Plaban Kumar Mondal over 1 year ago

  • % Done changed from 0 to 100

#10 Updated by Plaban Kumar Mondal about 1 year ago

  • Assignee deleted (Plaban Kumar Mondal)

Also available in: Atom PDF