Project

General

Profile

Actions
Copy link

Bug #44641

closed

nautilus: do_cmake.sh does not apply -DWITH_RADOSGW_KAFKA_ENDPOINT=OFF on openSUSE

Added by Nathan Cutler about 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Nathan Cutler
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
34008
Crash signature (v1):
Crash signature (v2):

Description

The happens on openSUSE with today's nautilus (c8ba01fddef4ed6491300bfa690730e1d12821b5):

$ run-make-check.sh
...
...
02:23:44 + source /etc/os-release
02:23:44 ++ NAME='openSUSE Leap'
02:23:44 ++ VERSION=15.1
02:23:44 ++ ID=opensuse-leap
02:23:44 ++ ID_LIKE='suse opensuse'
02:23:44 ++ VERSION_ID=15.1
02:23:44 ++ PRETTY_NAME='openSUSE Leap 15.1'
02:23:44 ++ ANSI_COLOR='0;32'
02:23:44 ++ CPE_NAME=cpe:/o:opensuse:leap:15.1
02:23:44 ++ BUG_REPORT_URL=https://bugs.opensuse.org
02:23:44 ++ HOME_URL=https://www.opensuse.org/
02:23:44 + case "$ID" in
02:23:44 + PYBUILD=3
02:23:44 + WITH_RADOSGW_AMQP_ENDPOINT=OFF
02:23:44 + WITH_RADOSGW_KAFKA_ENDPOINT=OFF
02:23:44 + '[' 3 = 3 ']'
02:23:44 + ARGS=' -DWITH_PYTHON2=OFF -DWITH_PYTHON3=ON -DMGR_PYTHON_VERSION=3'
02:23:44 + type ccache
02:23:44 + echo 'enabling ccache'
02:23:44 enabling ccache
02:23:44 + ARGS=' -DWITH_PYTHON2=OFF -DWITH_PYTHON3=ON -DMGR_PYTHON_VERSION=3 -DWITH_CCACHE=ON'
02:23:44 + '[' -n OFF ']'
02:23:44 + ARGS=' -DWITH_PYTHON2=OFF -DWITH_PYTHON3=ON -DMGR_PYTHON_VERSION=3 -DWITH_CCACHE=ON -DWITH_RADOSGW_AMQP_ENDPOINT=OFF'
02:23:44 + mkdir build
02:23:44 + cd build
02:23:44 + type cmake3
02:23:44 + CMAKE=cmake
02:23:44 + cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_PYTHON2=OFF -DWITH_PYTHON3=ON -DMGR_PYTHON_VERSION=3 -DWITH_CCACHE=ON -DWITH_RADOSGW_AMQP_ENDPOINT=OFF -DWITH_GTEST_PARALLEL=ON -DWITH_FIO=ON -DWITH_SEASTAR=ON -DBOOST_J=8 -DENABLE_GIT_VERSION=OFF -DWITH_LTTNG=false -DWITH_BABELTRACE=false ..

Notice that we have "-DWITH_RADOSGW_AMQP_ENDPOINT=OFF" in the cmake command, but WITH_RADOSGW_KAFKA_ENDPOINT=OFF is missing.

Also notice:

02:23:44 + WITH_RADOSGW_AMQP_ENDPOINT=OFF
02:23:44 + WITH_RADOSGW_KAFKA_ENDPOINT=OFF
02:23:44 + '[' 3 = 3 ']'
02:23:44 + ARGS=' -DWITH_PYTHON2=OFF -DWITH_PYTHON3=ON -DMGR_PYTHON_VERSION=3'

ARGS is getting reset?

Actions
Copy link
 #1

Updated by Nathan Cutler about 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Nathan Cutler about 4 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Nathan Cutler about 4 years ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Nathan Cutler about 4 years ago

  • Description updated (diff)
Actions
Copy link
 #5

Updated by Nathan Cutler about 4 years ago

Here is the offending code:

dca11c6f60fa (Willem Jan Withagen 2019-03-02 15:37:38 +0100 24)       opensuse*|suse|sles)
dca11c6f60fa (Willem Jan Withagen 2019-03-02 15:37:38 +0100 25)           PYBUILD="3" 
dca11c6f60fa (Willem Jan Withagen 2019-03-02 15:37:38 +0100 26)           WITH_RADOSGW_AMQP_ENDPOINT="OFF" 
dca11c6f60fa (Willem Jan Withagen 2019-03-02 15:37:38 +0100 27)           WITH_RADOSGW_KAFKA_ENDPOINT="OFF" 
dca11c6f60fa (Willem Jan Withagen 2019-03-02 15:37:38 +0100 28)           ;;
dca11c6f60fa (Willem Jan Withagen 2019-03-02 15:37:38 +0100 29)   esac
dca11c6f60fa (Willem Jan Withagen 2019-03-02 15:37:38 +0100 30) elif [ "$(uname)" == FreeBSD ] ; then
dca11c6f60fa (Willem Jan Withagen 2019-03-02 15:37:38 +0100 31)   PYBUILD="3" 
dca11c6f60fa (Willem Jan Withagen 2019-03-02 15:37:38 +0100 32)   WITH_RADOSGW_AMQP_ENDPOINT="OFF" 
dca11c6f60fa (Willem Jan Withagen 2019-03-02 15:37:38 +0100 33)   WITH_RADOSGW_KAFKA_ENDPOINT="OFF" 
dca11c6f60fa (Willem Jan Withagen 2019-03-02 15:37:38 +0100 34) else

Compare with the relevant passage in master:

46b3d671b440 (Willem Jan Withagen 2019-03-02 15:37:38 +0100 30)       opensuse*|suse|sles)
46b3d671b440 (Willem Jan Withagen 2019-03-02 15:37:38 +0100 31)           PYBUILD="3" 
612376a74964 (Kefu Chai           2019-09-28 22:15:15 +0800 32)           ARGS+=" -DWITH_RADOSGW_AMQP_ENDPOINT=OFF" 
354d775e04e3 (Yuval Lifshitz      2019-10-10 16:27:35 +0300 33)           ARGS+=" -DWITH_RADOSGW_KAFKA_ENDPOINT=OFF" 
46b3d671b440 (Willem Jan Withagen 2019-03-02 15:37:38 +0100 34)           ;;
46b3d671b440 (Willem Jan Withagen 2019-03-02 15:37:38 +0100 35)   esac
46b3d671b440 (Willem Jan Withagen 2019-03-02 15:37:38 +0100 36) elif [ "$(uname)" == FreeBSD ] ; then
46b3d671b440 (Willem Jan Withagen 2019-03-02 15:37:38 +0100 37)   PYBUILD="3" 
612376a74964 (Kefu Chai           2019-09-28 22:15:15 +0800 38)   ARGS+=" -DWITH_RADOSGW_AMQP_ENDPOINT=OFF" 
354d775e04e3 (Yuval Lifshitz      2019-10-10 16:27:35 +0300 39)   ARGS+=" -DWITH_RADOSGW_KAFKA_ENDPOINT=OFF" 
46b3d671b440 (Willem Jan Withagen 2019-03-02 15:37:38 +0100 40) else

So perhaps it's just a matter of missing backports.

Actions
Copy link
 #6

Updated by Nathan Cutler about 4 years ago

  • Subject changed from make tries to compile kafka_stub (run-make-check.sh on openSUSE) to nautilus: make tries to compile kafka_stub (run-make-check.sh on openSUSE)
  • Backport deleted (octopus, nautilus)
Actions
Copy link
 #7

Updated by Nathan Cutler about 4 years ago

  • Status changed from New to Fix Under Review
  • Pull request ID set to 34008
Actions
Copy link
 #8

Updated by Nathan Cutler about 4 years ago

  • Subject changed from nautilus: make tries to compile kafka_stub (run-make-check.sh on openSUSE) to nautilus: do_cmake.sh does not apply -DWITH_RADOSGW_KAFKA_ENDPOINT=OFF on openSUSE
Actions
Copy link
 #9

Updated by Nathan Cutler about 4 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link

Also available in: Atom PDF