Project

General

Profile

Bug #44319

mgr/dashboard: make check mypy failure

Added by Laura Paduano 7 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Q/A
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

make check currently fails due to:

mypy create: /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/.tox/mypy
mypy installdeps: -rrequirements.txt, mypy
WARNING: Discarding $PYTHONPATH from environment, to override specify PYTHONPATH in 'passenv' in your configuration.
mypy installed: -f /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/wheelhouse,attrs==19.3.0,cachetools==4.0.0,-e git+https://github.com/ceph/ceph.git@389dbf1d09b81fcf93a02c57a214016f07d5346c#egg=ceph&subdirectory=src/python-common,certifi==2019.11.28,cffi==1.14.0,chardet==3.0.4,coverage==5.0.3,cryptography==2.8,google-auth==1.11.2,idna==2.9,importlib-metadata==1.5.0,kubernetes==10.0.1,more-itertools==8.2.0,mypy==0.761,mypy-extensions==0.4.3,oauthlib==3.1.0,packaging==20.1,pluggy==0.13.1,prettytable==0.7.2,py==1.8.1,pyasn1==0.4.8,pyasn1-modules==0.2.8,pycparser==2.19,pyOpenSSL==19.1.0,pyparsing==2.4.6,pytest==5.3.5,pytest-cov==2.7.1,python-dateutil==2.8.1,PyYAML==5.3,requests==2.23.0,requests-mock==1.7.0,requests-oauthlib==1.3.0,rsa==4.0,six==1.14.0,typed-ast==1.4.1,typing-extensions==3.7.4.1,urllib3==1.25.8,wcwidth==0.1.8,websocket-client==0.57.0,zipp==3.0.0
mypy run-test-pre: PYTHONHASHSEED='4122218302'
mypy run-test: commands[0] | mypy --config-file=../../mypy.ini cephadm/module.py mgr_module.py dashboard/module.py mgr_util.py orchestrator/__init__.py progress/module.py rook/module.py osd_support/module.py test_orchestrator/module.py
dashboard/services/exception.py:14: note: In module imported here,
dashboard/module.py:50: note: ... from here:
dashboard/services/ceph_service.py: note: In member "get_smart_data_by_daemon" of class "CephService":
dashboard/services/ceph_service.py:262: error: Need type annotation for 'smart_data' (hint: "smart_data: Dict[<type>, <type>] = ...")
Found 1 error in 1 file (checked 9 source files)
ERROR: InvocationError for command /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/.tox/mypy/bin/mypy --config-file=../../mypy.ini cephadm/module.py mgr_module.py dashboard/module.py mgr_util.py orchestrator/__init__.py progress/module.py rook/module.py osd_support/module.py test_orchestrator/module.py (exited with code 1)

History

#1 Updated by Volker Theile 7 months ago

  • Subject changed from make check mypy failure to mgr/dashboard: make check mypy failure

#2 Updated by Volker Theile 7 months ago

  • Status changed from In Progress to Fix Under Review
  • Pull request ID set to 33573

#3 Updated by Laura Paduano 6 months ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v16.0.0

Also available in: Atom PDF