Project

General

Profile

Actions
Copy link

Bug #43895

closed

ceph --version gives external git reference as ceph version.

Added by Tony Davies about 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Nathan Cutler
Category:
-
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
v14.2.6
ceph-qa-suite:
Pull request ID:
34369
Crash signature (v1):
Crash signature (v2):

Description

When makinging the ceph orig tar.gz ceph uses a git reference external to the ceph source tree.

This occurs because of the recursive check to / in cmake/modules/GetGitRevisionDescription.cmake get_git_head_revision searching for a .git directory.

I have added a patch that will provide a fix by stopping at $CMAKE_SOURCE_DIR.

This patch has worked successfully for me on x86_64 and aarch64 (and armv7).

It was created and tested on 1.4.2.6 (ceph_14.2.6.orig.tar.gz)

Files

git_search_fix.patch (1 KB) git_search_fix.patch Tony Davies, 01/30/2020 09:50 AM
Actions
Copy link
 #1

Updated by Nathan Cutler about 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Nathan Cutler
  • Pull request ID set to 34369

@Tony - your patch looks good to me. I opened it as GitHub PR https://github.com/ceph/ceph/pull/34369 so it can be reviewed.

Actions
Copy link
 #2

Updated by Kefu Chai about 4 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF