Project

General

Profile

Actions

Bug #43753

open

mgr/dashboard: OSD flags editing response is not correct

Added by Tatjana Dehler over 4 years ago. Updated about 3 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Component - OSDs
Target version:
-
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

This issue is only about the REST API layer of the dashboard. The web UI is handling the following issue correctly.

When I'm sending a PUT-request to https://localhost:9080/api/osd/flags containing the following body:

{
  "flags": ["noscrub"]
}

I'm receiving the following response:

400 Error: Bad Request

{
  "detail": "[errno -22] unrecognized flag 'sortbitwise'",
  "code": "SendCommandError",
  "component": null
}

which makes sense accordingly to the comment in the OsdFlagsController:bulk_set endpoint (https://github.com/ceph/ceph/blob/master/src/pybind/mgr/dashboard/controllers/osd.py):

The `recovery_deletes`, `sortbitwise` and `pglog_hardlimit` flags cannot be unset.
`purged_snapshots` cannot even be set. It is therefore required to at
least include those four flags for a successful operation.
Afterwards the added flag (e.g. noscrub) is set although the REST API is returning an error response.
From my point of view either:
  • the REST API shouldn't send an error response or
  • the backend shouldn't set the flag anyway
Actions #1

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
  • Category changed from 138 to Component - OSDs
Actions

Also available in: Atom PDF