Bug #43523: mgr/dashboard: UserForm 'pwdExpirationDate' field is shown wrongly - Dashboard - Ceph

Actions

Copy link

Bug #43523

closed

mgr/dashboard: UserForm 'pwdExpirationDate' field is shown wrongly

Added by Tatjana Dehler over 4 years ago. Updated about 3 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Tatjana Dehler

Category:

Target version:

% Done:

Source:

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

32703

Crash signature (v1):

Crash signature (v2):

Actions

Copy link

Updated by Tatjana Dehler over 4 years ago

Subject changed from mgr/dashboard: UserForm 'pwdExpirationDate' is shown wrongly to mgr/dashboard: UserForm 'pwdExpirationDate' field is shown wrongly
Category set to 152
Assignee set to Tatjana Dehler

If I create a user the password expiration field is not shown until I touch the form. As soon as I touch a form field, the password expiration field appears.

When should the field be shown?

User create: If the password expiration span is defined.
User edit: If the password expiration span is defined OR a password expiration date has already been set for the user

Actions

Copy link

Updated by Volker Theile over 4 years ago

IMO the field should be always visible.

Actions

Copy link

Updated by Tatjana Dehler over 4 years ago

Volker Theile wrote:

IMO the field should be always visible.

I'm also fine with it, if we all agree on it.

Although I'm wondering how we handle the following case:

Password expiration span is not defined
~~> The admin creates a new user and defines a password expiration date~~
> The user updates his password within the given time span

Without the password expiration time span it's not possible to calculate a new expiration date. It means the password won't expire anymore (except the admin sets a new date manually).

Actions

Copy link

Updated by Tiago Melo over 4 years ago

I'm OK with both options.

If there is no time span defined, when the user changes the password I would simply remove the expiration date.
If the admin wants, he can add it again.

To help the admin with this we could add an help text in the password expiry form field, informing the user that the time span is not configured and it would be a 1 time thing.

Actions

Copy link

Updated by Tatjana Dehler over 4 years ago

Tiago Melo wrote:

I'm OK with both options.

If there is no time span defined, when the user changes the password I would simply remove the expiration date.
If the admin wants, he can add it again.

To help the admin with this we could add an help text in the password expiry form field, informing the user that the time span is not configured and it would be a 1 time thing.

Sounds good to me!

Actions

Copy link