Project

General

Profile

Actions
Copy link

Bug #43313

closed

telemetry module can crash on entity name with multiple '.' separators

Added by Dan Mick over 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Dan Mick
Category:
-
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
nautilus,mimic
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
33094
Crash signature (v1):
Crash signature (v2):

Description

A user discovered this:

        # ceph telemetry show
        Error EINVAL: Traceback (most recent call last):
          File "/usr/share/ceph/mgr/mgr_module.py", line 914, in _handle_command
            return self.handle_command(inbuf, cmd)
          File "/usr/share/ceph/mgr/telemetry/module.py", line 754, in handle_command
            channels=command.get('channels', None)
          File "/usr/share/ceph/mgr/telemetry/module.py", line 660, in compile_report
            report['crashes'] = self.gather_crashinfo()
          File "/usr/share/ceph/mgr/telemetry/module.py", line 337, in gather_crashinfo
            (etype, eid) = c.get('entity_name', '').split('.')
        ValueError: too many values to unpack

The entity name in question was 

client.rgw.stage2-rgw02-object02.s2r6
, which indeed won't split correctly. The fix is to add a max-split count of 1 so that only the first '.' is considered a separator.

Related issues 2 (0 open — 2 closed)

Copied to mgr - Backport #44057: nautilus: telemetry module can crash on entity name with multiple '.' separatorsResolvedKonstantin ShalyginActions
Copied to mgr - Backport #44058: mimic: telemetry module can crash on entity name with multiple '.' separatorsRejectedActions
Actions
Copy link

Also available in: Atom PDF