Bug #42872
closed
qa/tasks: add remaining tests for fs volume
Added by Jos Collin over 4 years ago.
Updated about 4 years ago.
Category:
Correctness/Safety
Component(FS):
mgr/volumes, qa-suite
Description
There are missing tests for `fs volume` in test_volumes.py. Only test_volume_rm is available. Where are the tests for `fs volume create` and `fs volume ls`?
- Status changed from New to Need More Info
- Assignee set to Jos Collin
- Target version set to v15.0.0
- Backport set to nautilus
- Component(FS) mgr/volumes added
- Status changed from Need More Info to Closed
We cannot test this with accuracy.
Because:
`ceph fs volume ls` would list the already existing volumes and the default volume(s). So we don't know what is already there and what to compare with. There is no other way to know the entire list of volumes, so that we could compare the results.
To test `ceph fs volume create`, there is no getpath function/command to verify if the new volume is actually created or not. We could catch the exception here https://github.com/ceph/ceph/blob/master/qa/tasks/cephfs/test_volumes.py#L53, but it seems the subvolume tests that uses self.volname indirectly confirms that a volume could be created.
So closing this ticket.
- Status changed from Closed to New
Jos Collin wrote:
We cannot test this with accuracy.
Because:
`ceph fs volume ls` would list the already existing volumes and the default volume(s). So we don't know what is already there and what to compare with. There is no other way to know the entire list of volumes, so that we could compare the results.
Write a method to delete all volumes and then do tests for create. Likewise for ls.
To test `ceph fs volume create`, there is no getpath function/command to verify if the new volume is actually created or not.
Write one! Then do a client mount.
We could catch the exception here https://github.com/ceph/ceph/blob/master/qa/tasks/cephfs/test_volumes.py#L53, but it seems the subvolume tests that uses self.volname indirectly confirms that a volume could be created.
The volume was not created using `fs volume`. It's just the usual file system creation as part of QA tests. (Note: `fs volume` and `fs new` are basically equivalent from the perspective of the volumes plugin.)
So closing this ticket.
Reopening!
- Status changed from New to In Progress
- Pull request ID set to 31884
- Status changed from In Progress to Fix Under Review
- Status changed from Fix Under Review to Pending Backport
- Copied to Backport #43338: nautilus: qa/tasks: add remaining tests for fs volume added
- Status changed from Pending Backport to Resolved
Also available in: Atom
PDF