Ceph » CephFS

I checked Migrator.cc for creation of MutationImpl object and setting of its TrackedOp initiated_at attribute mentioned in the Description.

src/mds/Migrator.cc
1334: it->second.mut = new MutationImpl();
2583: it->second.mut = new MutationImpl();

The above two happens at Migrator::export_frozen and Migrator::handle_export_prep respectively. In both the methods, the MutationImpl/TrackedOp "initiated_at" of a CDir's export_state_t is not set anywhere else later in the code. I'm guessing the TrackedOp "initiated_at" is not used/useful in Migrator related code.

In src/mds/MDCache.cc,

MDCache.cc:534: MutationRef mut(new MutationImpl());

The above code is in MDCache::_create_system_file

MDCache.cc:6489: MutationRef mut(new MutationImpl());

The above code is in MDCache::truncate_inode_finish

MDCache.cc:12194: MutationRef mut(new MutationImpl());

The above code is in MDCache:: MDCache::rollback_uncommitted_fragments

In src/mds/CInode.cc,

CInode.cc:2356: MutationRef mut(new MutationImpl());

The above code is in CInode::finish_scatter_update

In src/mds/StrayManager.cc,

StrayManager.cc:183: MutationRef mut(new MutationImpl());
StrayManager.cc:221: MutationRef mut(new MutationImpl());

The above code is in StrayManager::_purge_stray_purged

In all the above occurrences, the "initated_at" is not set anywhere else in the respective methods or in their calling methods.

Looking at the MDS code base, MDRequestRef TrackedOps object "initiated_at" is set at MDCache::request_start, MDCache::request_start_internal, and MDCache::request_start_peer. e.g., MDCache::request_start gets called in Server::handle_client_request.

Ramana Raja wrote:

I checked Migrator.cc for creation of MutationImpl object and setting of its TrackedOp initiated_at attribute mentioned in the Description.

src/mds/Migrator.cc
1334: it->second.mut = new MutationImpl();
2583: it->second.mut = new MutationImpl();

The above two happens at Migrator::export_frozen and Migrator::handle_export_prep respectively. In both the methods, the MutationImpl/TrackedOp "initiated_at" of a CDir's export_state_t is not set anywhere else later in the code. I'm guessing the TrackedOp "initiated_at" is not used/useful in Migrator related code.

In src/mds/MDCache.cc,

MDCache.cc:534: MutationRef mut(new MutationImpl());

The above code is in MDCache::_create_system_file

MDCache.cc:6489: MutationRef mut(new MutationImpl());

The above code is in MDCache::truncate_inode_finish

MDCache.cc:12194: MutationRef mut(new MutationImpl());

The above code is in MDCache:: MDCache::rollback_uncommitted_fragments

In src/mds/CInode.cc,

CInode.cc:2356: MutationRef mut(new MutationImpl());

The above code is in CInode::finish_scatter_update

In src/mds/StrayManager.cc,

StrayManager.cc:183: MutationRef mut(new MutationImpl());
StrayManager.cc:221: MutationRef mut(new MutationImpl());

The above code is in StrayManager::_purge_stray_purged

In all the above occurrences, the "initated_at" is not set anywhere else in the respective methods or in their calling methods.

Looking at the MDS code base, MDRequestRef TrackedOps object "initiated_at" is set at MDCache::request_start, MDCache::request_start_internal, and MDCache::request_start_peer. e.g., MDCache::request_start gets called in Server::handle_client_request.

I don't see a way to updated initiated_at post-creation for TrackedOp. I think the right change here is to initialize with the current time rather than utime_t(). What do you think?